You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/28 10:13:46 UTC

[GitHub] [airflow] potiuk commented on pull request #23981: Remove `xcom_push` from `DockerOperator`

potiuk commented on PR #23981:
URL: https://github.com/apache/airflow/pull/23981#issuecomment-1140228471

   I'd love to hear what other think, but I consider it a heavily breaking change and we should not do it (at least not in this form). 
   
   The problem with such changes is that it REQUIRES the users to migrate all their dags (in one go in case they use it) . There were at least a few talks at the Airflow Summit that it was mentioned that changes that require the users to modify breaking changes are ones that are extremely costly for the users to migrate and making it mandatory for all the users is something that:
   
   a) we will get a lot of complaints about
   b) is not compatible with our SEMVER approach - this is clearle a change that breaks the current API of the most basic feature we have
   c) will hold the users from migrations
   
   The premise we have with introducing Semver is that we try to convince our users that it is "easy" to migrate to latest version of Airflow. If we merge this change without going to Airlfow 3 we are breaking that premise IMHO.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org