You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2018/04/10 17:24:20 UTC

[GitHub] reta commented on a change in pull request #398: [Draft] SSE implementation using AsyncContext

reta commented on a change in pull request #398: [Draft] SSE implementation using AsyncContext
URL: https://github.com/apache/cxf/pull/398#discussion_r180503481
 
 

 ##########
 File path: systests/rs-sse/rs-sse-base/src/main/java/org/apache/cxf/systest/jaxrs/sse/BookStore.java
 ##########
 @@ -124,6 +124,7 @@ public void stop() {
             broadcaster.broadcast(createStatsEvent(builder.name("book"), 1000));
             broadcaster.broadcast(createStatsEvent(builder.name("book"), 2000));
 
+            Thread.sleep(2000);
 
 Review comment:
   The fix would be (I think) to wrap `broadcaster.broadcast` calls into `CompletableFuture.allOf` and add `whenCompleted` callback to close the broadcaster.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services