You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/02/12 21:41:23 UTC
[kudu-CR] [CMakeLists] get rid of warnings in ASAN builds
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12459
Change subject: [CMakeLists] get rid of warnings in ASAN builds
......................................................................
[CMakeLists] get rid of warnings in ASAN builds
This patch updates the flags for ASAN builds to get rid of the
warnings like below:
clang-6.0: warning: argument '-fno-sanitize-recover' is deprecated, \
use '-fno-sanitize-recover=undefined,integer' or \
'-fno-sanitize-recover=all' instead [-Wdeprecated]
This is a follow-up to 678dbac6fb05d0370e40e6645d4b1ec530fa0180.
Change-Id: I0a5877ed1743387881ab1d31f42519a361b64ea7
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/12459/1
--
To view, visit http://gerrit.cloudera.org:8080/12459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a5877ed1743387881ab1d31f42519a361b64ea7
Gerrit-Change-Number: 12459
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [CMakeLists] get rid of warnings in ASAN builds
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12459 )
Change subject: [CMakeLists] get rid of warnings in ASAN builds
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12459/1/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/12459/1/CMakeLists.txt@356
PS1, Line 356: set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-sanitize-recover=all")
Are you sure this is the right conversion? Won't this mean that ASAN errors will halt too? Seems like converting this to =undefined,integer is the safer course of action.
--
To view, visit http://gerrit.cloudera.org:8080/12459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a5877ed1743387881ab1d31f42519a361b64ea7
Gerrit-Change-Number: 12459
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 12 Feb 2019 23:48:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] [CMakeLists] get rid of warnings in ASAN builds
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12459 )
Change subject: [CMakeLists] get rid of warnings in ASAN builds
......................................................................
[CMakeLists] get rid of warnings in ASAN builds
This patch updates the flags for ASAN builds to get rid of the
warnings like below:
clang-6.0: warning: argument '-fno-sanitize-recover' is deprecated, \
use '-fno-sanitize-recover=undefined,integer' or \
'-fno-sanitize-recover=all' instead [-Wdeprecated]
This is a follow-up to 678dbac6fb05d0370e40e6645d4b1ec530fa0180.
Change-Id: I0a5877ed1743387881ab1d31f42519a361b64ea7
Reviewed-on: http://gerrit.cloudera.org:8080/12459
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a5877ed1743387881ab1d31f42519a361b64ea7
Gerrit-Change-Number: 12459
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [CMakeLists] get rid of warnings in ASAN builds
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12459
to look at the new patch set (#2).
Change subject: [CMakeLists] get rid of warnings in ASAN builds
......................................................................
[CMakeLists] get rid of warnings in ASAN builds
This patch updates the flags for ASAN builds to get rid of the
warnings like below:
clang-6.0: warning: argument '-fno-sanitize-recover' is deprecated, \
use '-fno-sanitize-recover=undefined,integer' or \
'-fno-sanitize-recover=all' instead [-Wdeprecated]
This is a follow-up to 678dbac6fb05d0370e40e6645d4b1ec530fa0180.
Change-Id: I0a5877ed1743387881ab1d31f42519a361b64ea7
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/12459/2
--
To view, visit http://gerrit.cloudera.org:8080/12459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0a5877ed1743387881ab1d31f42519a361b64ea7
Gerrit-Change-Number: 12459
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [CMakeLists] get rid of warnings in ASAN builds
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12459 )
Change subject: [CMakeLists] get rid of warnings in ASAN builds
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12459/1/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/12459/1/CMakeLists.txt@356
PS1, Line 356: set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-sanitize-recover=all")
> Are you sure this is the right conversion? Won't this mean that ASAN errors
I would expect it to affect only the sanitized cases.
However, since we explicitly ask to sanitize UB and integer-related issue, probably -fno-sanitize-recover=undefined,integer is a better choice here.
Done.
--
To view, visit http://gerrit.cloudera.org:8080/12459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a5877ed1743387881ab1d31f42519a361b64ea7
Gerrit-Change-Number: 12459
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 13 Feb 2019 00:43:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] [CMakeLists] get rid of warnings in ASAN builds
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12459 )
Change subject: [CMakeLists] get rid of warnings in ASAN builds
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12459/1/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/12459/1/CMakeLists.txt@356
PS1, Line 356: set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-sanitize-recover=all")
> The issue is that we typically build with both -DKUDU_USE_ASAN=1 and -DKUDU
Ah, I see. Thanks for the clarification.
--
To view, visit http://gerrit.cloudera.org:8080/12459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a5877ed1743387881ab1d31f42519a361b64ea7
Gerrit-Change-Number: 12459
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 13 Feb 2019 02:04:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] [CMakeLists] get rid of warnings in ASAN builds
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12459 )
Change subject: [CMakeLists] get rid of warnings in ASAN builds
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12459/1/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/12459/1/CMakeLists.txt@356
PS1, Line 356: set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-sanitize-recover=undefined,integer")
> I would expect it to affect only the sanitized cases.
The issue is that we typically build with both -DKUDU_USE_ASAN=1 and -DKUDU_USE_UBSAN=1 (that's how our 'ASAN' build type works), so we'll end up running multiple sanitizers simultaneously. In that case, 'all' will affect more than just UB and integers.
--
To view, visit http://gerrit.cloudera.org:8080/12459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a5877ed1743387881ab1d31f42519a361b64ea7
Gerrit-Change-Number: 12459
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 13 Feb 2019 01:36:40 +0000
Gerrit-HasComments: Yes