You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltacloud.apache.org by mf...@redhat.com on 2012/05/15 17:15:58 UTC
[PATCH core 26/26] FGCP: Fixed configuration of providers
From: Michal Fojtik <mf...@redhat.com>
Signed-off-by: Michal fojtik <mf...@redhat.com>
---
server/config/drivers/fgcp.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/server/config/drivers/fgcp.yaml b/server/config/drivers/fgcp.yaml
index 8c24f66..838b710 100644
--- a/server/config/drivers/fgcp.yaml
+++ b/server/config/drivers/fgcp.yaml
@@ -4,6 +4,7 @@
:username: Username
:password: Secret Key Password of User Certificate
:entrypoints:
+ default:
jp: https://api.oviss.jp.fujitsu.com/ovissapi/endpoint
au: https://api.globalcloud.fujitsu.com.au/ovissapi/endpoint
sg: https://api.globalcloud.sg.fujitsu.com/ovissapi/endpoint
--
1.7.10.1
Re: [PATCH core 26/26] FGCP: Fixed configuration of providers
Posted by Michal Fojtik <mi...@mifo.sk>.
On 16 May 2012, at 4:02, Koper, Dies wrote:
Hi Dies,
Then I vote for updating the client and driver, because without this
patch the GET /api/drivers?format=xml returns:
NoMethodError - undefined method `each' for
"https://api.oviss.jp.fujitsu.com/ovissapi/endpoint":String:
/Users/mfojtik/code/deltacloud/server/lib/deltacloud/helpers/deltacloud_helper.rb:188:in
`block in driver_provider'
/Users/mfojtik/code/deltacloud/server/lib/deltacloud/helpers/deltacloud_helper.rb:187:in
`each'
/Users/mfojtik/code/deltacloud/server/lib/deltacloud/helpers/deltacloud_helper.rb:187:in
`driver_provider'
/Users/mfojtik/code/deltacloud/server/lib/deltacloud/../../views/drivers/index.xml.haml:6:in
`block in evaluate_source'
/Users/mfojtik/code/deltacloud/server/lib/deltacloud/../../views/drivers/index.xml.haml:2:in
`each'
/Users/mfojtik/code/deltacloud/server/lib/deltacloud/../../views/drivers/index.xml.haml:2:in
`evaluate_source'
I'll send another patch that will update the driver.
-- michal
> NACK
>
> This change breaks authentication.
> I see 'default' in other yaml files so I suppose it should be there.
>
> We have the following in several places in fgcp_client.rb and
> fgcp_driver.rb.
> They probably have to be updated at the same time.
>
> endpoint =
> Deltacloud::Drivers::driver_config[:fgcp][:entrypoints][country]
> unless
> endpoint
>
> Regards,
> Dies Koper
>
>
>> -----Original Message-----
>> From: mfojtik@redhat.com [mailto:mfojtik@redhat.com]
>> Sent: Wednesday, 16 May 2012 1:16 AM
>> To: dev@deltacloud.apache.org
>> Subject: [PATCH core 26/26] FGCP: Fixed configuration of providers
>>
>> From: Michal Fojtik <mf...@redhat.com>
>>
>>
>> Signed-off-by: Michal fojtik <mf...@redhat.com>
>> ---
>> server/config/drivers/fgcp.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/server/config/drivers/fgcp.yaml
>> b/server/config/drivers/fgcp.yaml
>> index 8c24f66..838b710 100644
>> --- a/server/config/drivers/fgcp.yaml
>> +++ b/server/config/drivers/fgcp.yaml
>> @@ -4,6 +4,7 @@
>> :username: Username
>> :password: Secret Key Password of User Certificate
>> :entrypoints:
>> + default:
>> jp: https://api.oviss.jp.fujitsu.com/ovissapi/endpoint
>> au: https://api.globalcloud.fujitsu.com.au/ovissapi/endpoint
>> sg: https://api.globalcloud.sg.fujitsu.com/ovissapi/endpoint
>> --
>> 1.7.10.1
>>
RE: [PATCH core 26/26] FGCP: Fixed configuration of providers
Posted by "Koper, Dies" <di...@fast.au.fujitsu.com>.
Hi Michal,
That didn't work but if you use ['default'] instead of [:default], it
does.
Could you also update line 1151 of the driver (although commented out)
so that if we reactivate this code at some point in the future I won't
have to scratch my head why it won't work? :)
# Deltacloud::Drivers::driver_config[:fgcp][:entrypoints].keys
Cheers,
Dies Koper
> -----Original Message-----
> From: Michal Fojtik [mailto:mi@mifo.sk]
> Sent: Wednesday, 16 May 2012 5:37 PM
> To: dev@deltacloud.apache.org
> Subject: Re: [PATCH core 26/26] FGCP: Fixed configuration of providers
>
> On 16 May 2012, at 4:02, Koper, Dies wrote:
>
> Hi again :-)
>
> So the patch is here:
>
> https://github.com/mifo/deltacloud/commit/478607bd34aeb23d7e38671
> 14f59f9b0cafe1379
>
> Let me know if you're OK with this fix.
>
> Cheers,
> Michal
>
> > NACK
> >
> > This change breaks authentication.
> > I see 'default' in other yaml files so I suppose it should be there.
> >
> > We have the following in several places in fgcp_client.rb and
> > fgcp_driver.rb.
> > They probably have to be updated at the same time.
> >
> > endpoint =
> > Deltacloud::Drivers::driver_config[:fgcp][:entrypoints][country]
> > unless
> > endpoint
> >
> > Regards,
> > Dies Koper
> >
> >
> >> -----Original Message-----
> >> From: mfojtik@redhat.com [mailto:mfojtik@redhat.com]
> >> Sent: Wednesday, 16 May 2012 1:16 AM
> >> To: dev@deltacloud.apache.org
> >> Subject: [PATCH core 26/26] FGCP: Fixed configuration of providers
> >>
> >> From: Michal Fojtik <mf...@redhat.com>
> >>
> >>
> >> Signed-off-by: Michal fojtik <mf...@redhat.com>
> >> ---
> >> server/config/drivers/fgcp.yaml | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/server/config/drivers/fgcp.yaml
> >> b/server/config/drivers/fgcp.yaml
> >> index 8c24f66..838b710 100644
> >> --- a/server/config/drivers/fgcp.yaml
> >> +++ b/server/config/drivers/fgcp.yaml
> >> @@ -4,6 +4,7 @@
> >> :username: Username
> >> :password: Secret Key Password of User Certificate
> >> :entrypoints:
> >> + default:
> >> jp: https://api.oviss.jp.fujitsu.com/ovissapi/endpoint
> >> au: https://api.globalcloud.fujitsu.com.au/ovissapi/endpoint
> >> sg: https://api.globalcloud.sg.fujitsu.com/ovissapi/endpoint
> >> --
> >> 1.7.10.1
> >>
Re: [PATCH core 26/26] FGCP: Fixed configuration of providers
Posted by Michal Fojtik <mi...@mifo.sk>.
On 16 May 2012, at 4:02, Koper, Dies wrote:
Hi again :-)
So the patch is here:
https://github.com/mifo/deltacloud/commit/478607bd34aeb23d7e3867114f59f9b0cafe1379
Let me know if you're OK with this fix.
Cheers,
Michal
> NACK
>
> This change breaks authentication.
> I see 'default' in other yaml files so I suppose it should be there.
>
> We have the following in several places in fgcp_client.rb and
> fgcp_driver.rb.
> They probably have to be updated at the same time.
>
> endpoint =
> Deltacloud::Drivers::driver_config[:fgcp][:entrypoints][country]
> unless
> endpoint
>
> Regards,
> Dies Koper
>
>
>> -----Original Message-----
>> From: mfojtik@redhat.com [mailto:mfojtik@redhat.com]
>> Sent: Wednesday, 16 May 2012 1:16 AM
>> To: dev@deltacloud.apache.org
>> Subject: [PATCH core 26/26] FGCP: Fixed configuration of providers
>>
>> From: Michal Fojtik <mf...@redhat.com>
>>
>>
>> Signed-off-by: Michal fojtik <mf...@redhat.com>
>> ---
>> server/config/drivers/fgcp.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/server/config/drivers/fgcp.yaml
>> b/server/config/drivers/fgcp.yaml
>> index 8c24f66..838b710 100644
>> --- a/server/config/drivers/fgcp.yaml
>> +++ b/server/config/drivers/fgcp.yaml
>> @@ -4,6 +4,7 @@
>> :username: Username
>> :password: Secret Key Password of User Certificate
>> :entrypoints:
>> + default:
>> jp: https://api.oviss.jp.fujitsu.com/ovissapi/endpoint
>> au: https://api.globalcloud.fujitsu.com.au/ovissapi/endpoint
>> sg: https://api.globalcloud.sg.fujitsu.com/ovissapi/endpoint
>> --
>> 1.7.10.1
>>
RE: [PATCH core 26/26] FGCP: Fixed configuration of providers
Posted by "Koper, Dies" <di...@fast.au.fujitsu.com>.
NACK
This change breaks authentication.
I see 'default' in other yaml files so I suppose it should be there.
We have the following in several places in fgcp_client.rb and
fgcp_driver.rb.
They probably have to be updated at the same time.
endpoint =
Deltacloud::Drivers::driver_config[:fgcp][:entrypoints][country] unless
endpoint
Regards,
Dies Koper
> -----Original Message-----
> From: mfojtik@redhat.com [mailto:mfojtik@redhat.com]
> Sent: Wednesday, 16 May 2012 1:16 AM
> To: dev@deltacloud.apache.org
> Subject: [PATCH core 26/26] FGCP: Fixed configuration of providers
>
> From: Michal Fojtik <mf...@redhat.com>
>
>
> Signed-off-by: Michal fojtik <mf...@redhat.com>
> ---
> server/config/drivers/fgcp.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/server/config/drivers/fgcp.yaml
> b/server/config/drivers/fgcp.yaml
> index 8c24f66..838b710 100644
> --- a/server/config/drivers/fgcp.yaml
> +++ b/server/config/drivers/fgcp.yaml
> @@ -4,6 +4,7 @@
> :username: Username
> :password: Secret Key Password of User Certificate
> :entrypoints:
> + default:
> jp: https://api.oviss.jp.fujitsu.com/ovissapi/endpoint
> au: https://api.globalcloud.fujitsu.com.au/ovissapi/endpoint
> sg: https://api.globalcloud.sg.fujitsu.com/ovissapi/endpoint
> --
> 1.7.10.1
>