[GitHub] [calcite] xndai commented on a change in pull request #1884: [CALCITE-3972] Allow RelBuilder to create RelNode with convention and use it for trait convert

[GitBox <gi...@apache.org>]

xndai commented on a change in pull request #1884:
URL: https://github.com/apache/calcite/pull/1884#discussion_r420520796



##########
File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java
##########
@@ -173,6 +173,12 @@ protected RelBuilder(Context context, RelOptCluster cluster,
         new RexSimplify(cluster.getRexBuilder(), predicates, executor);
   }
 
+  private RelBuilder(Context context, RelOptCluster cluster,
+                     RelOptSchema relOptSchema, Deque<Frame> stack) {
+    this(context, cluster, relOptSchema);
+    this.stack.addAll(stack);
+  }

Review comment:
       this is used by withRelFactories() in order to pass in stack.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org