You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/15 23:36:26 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request #1839: Fix compiling ballista in standalone mode, add build to CI
alamb opened a new pull request #1839:
URL: https://github.com/apache/arrow-datafusion/pull/1839
# Which issue does this PR close?
TBD
# Rationale for this change
As pointed by @thinkharderdev on https://github.com/apache/arrow-datafusion/pull/1810 https://github.com/apache/arrow-datafusion/pull/1810#discussion_r807259524 compiling with ballista is currently broken (likely by https://github.com/apache/arrow-datafusion/pull/1677 and https://github.com/apache/arrow-datafusion/pull/1715):
```rust
(arrow_dev) alamb@MacBook-Pro-2:~/Software/arrow-datafusion/ballista/rust$ cargo test --no-default-features --features standalone
Compiling etcd-client v0.8.3
Compiling ballista-scheduler v0.6.0 (/Users/alamb/Software/arrow-datafusion/ballista/rust/scheduler)
Compiling ballista v0.6.0 (/Users/alamb/Software/arrow-datafusion/ballista/rust/client)
error[E0061]: this function takes 3 arguments but 2 arguments were supplied
--> ballista/rust/client/src/context.rs:93:9
|
93 | ballista_executor::new_standalone_executor(scheduler, concurrent_tasks).await?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ --------- ---------------- supplied 2 arguments
| |
| expected 3 arguments
|
note: function defined here
--> /Users/alamb/Software/arrow-datafusion/ballista/rust/executor/src/standalone.rs:38:14
|
38 | pub async fn new_standalone_executor<
| ^^^^^^^^^^^^^^^^^^^^^^^
For more information about this error, try `rustc --explain E0061`.
error: could not compile `ballista` due to previous error
warning: build failed, waiting for other jobs to finish...
error: build failed
```
# What changes are included in this PR?
1. Fix compile
2. Add to CI
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #1839: Fix compiling ballista in standalone mode, add build to CI
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1839:
URL: https://github.com/apache/arrow-datafusion/pull/1839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] thinkharderdev commented on a change in pull request #1839: Fix compiling ballista in standalone mode, add build to CI
Posted by GitBox <gi...@apache.org>.
thinkharderdev commented on a change in pull request #1839:
URL: https://github.com/apache/arrow-datafusion/pull/1839#discussion_r807789167
##########
File path: ballista/rust/client/src/context.rs
##########
@@ -458,13 +469,16 @@ mod tests {
#[tokio::test]
#[cfg(feature = "standalone")]
+ #[ignore]
Review comment:
yeah, that's where I got stuck as well :). I can take a look at the failing test and fix it another PR. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1839: Fix compiling ballista in standalone mode, add build to CI
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #1839:
URL: https://github.com/apache/arrow-datafusion/pull/1839#discussion_r807410799
##########
File path: ballista/rust/client/src/context.rs
##########
@@ -458,13 +469,16 @@ mod tests {
#[tokio::test]
#[cfg(feature = "standalone")]
+ #[ignore]
Review comment:
This test is failing 🦜 😢 : https://github.com/apache/arrow-datafusion/issues/1840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org