[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #3769: Upgrade commons compress from 1.19 to 1.21

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #3769:
URL: https://github.com/apache/netbeans/pull/3769#discussion_r825344523



##########
File path: java/java.disco/nbproject/project.xml
##########
@@ -82,6 +82,15 @@
                         <specification-version>1.18</specification-version>
                     </run-dependency>
                 </dependency>
+                <dependency>

Review comment:
       This is the dependency I'm missing in `db.dataview`.

##########
File path: ide/db.dataview/nbproject/project.properties
##########
@@ -26,7 +26,7 @@ test.unit.cp.extra=\
         ${basedir}/external/ooxml-schemas-1.4.jar:\
         ${basedir}/external/xmlbeans-3.1.0.jar:\
         ${basedir}/external/commons-collections4-4.4.jar:\
-        ${basedir}/external/commons-compress-1.20.jar
+        ${nb_all}/ide/libs.commons_compress/external/commons-compress-1.21.jar

Review comment:
       How is commons-compress made available to `db.dataview` without a dependency? Even if it is not strictly necessary, it would be good to have it, so scan of user of the module will also find it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists