You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/17 00:49:54 UTC
[GitHub] [arrow] TurnOfACard opened a new pull request #9222: [ARROW-11279][Rust][Parquet] ArrowWriter Definition Levels Memory Usage
TurnOfACard opened a new pull request #9222:
URL: https://github.com/apache/arrow/pull/9222
Writes leaves immediately after calculating array levels to reduce array level memory usage by the number of rows in a row group.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me closed pull request #9222: ARROW-11279: [Rust][Parquet] ArrowWriter Definition Levels Memory Usage
Posted by GitBox <gi...@apache.org>.
nevi-me closed pull request #9222:
URL: https://github.com/apache/arrow/pull/9222
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9222: ARROW-11279: [Rust][Parquet] ArrowWriter Definition Levels Memory Usage
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9222:
URL: https://github.com/apache/arrow/pull/9222#issuecomment-761709853
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9222?src=pr&el=h1) Report
> Merging [#9222](https://codecov.io/gh/apache/arrow/pull/9222?src=pr&el=desc) (adf3fdf) into [master](https://codecov.io/gh/apache/arrow/commit/1393188e1aa1b3d59993ce7d4ade7f7ac8570959?el=desc) (1393188) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow/pull/9222?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9222 +/- ##
==========================================
- Coverage 81.61% 81.60% -0.01%
==========================================
Files 215 215
Lines 51867 51863 -4
==========================================
- Hits 42329 42324 -5
- Misses 9538 9539 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9222?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/parquet/src/arrow/arrow\_writer.rs](https://codecov.io/gh/apache/arrow/pull/9222/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9hcnJvd193cml0ZXIucnM=) | `95.32% <100.00%> (-0.27%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9222?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9222?src=pr&el=footer). Last update [eaa7b7a...adf3fdf](https://codecov.io/gh/apache/arrow/pull/9222?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9222: ARROW-11279: [Rust][Parquet] ArrowWriter Definition Levels Memory Usage
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9222:
URL: https://github.com/apache/arrow/pull/9222#issuecomment-761707457
https://issues.apache.org/jira/browse/ARROW-11279
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9222: [ARROW-11279][Rust][Parquet] ArrowWriter Definition Levels Memory Usage
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9222:
URL: https://github.com/apache/arrow/pull/9222#issuecomment-761707043
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9222: ARROW-11279: [Rust][Parquet] ArrowWriter Definition Levels Memory Usage
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9222:
URL: https://github.com/apache/arrow/pull/9222#issuecomment-761773356
I apologize for the delay in merging Rust PRs -- the 3.0 release is being finalized now and are planning to minimize entropy by postponing merging changes not critical for the release until the process was complete. I hope the process is complete in the next few days. There is more [discussion](https://lists.apache.org/list.html?dev@arrow.apache.org) in the mailing list
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9222: ARROW-11279: [Rust][Parquet] ArrowWriter Definition Levels Memory Usage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9222:
URL: https://github.com/apache/arrow/pull/9222#issuecomment-761709853
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9222?src=pr&el=h1) Report
> Merging [#9222](https://codecov.io/gh/apache/arrow/pull/9222?src=pr&el=desc) (daaf2a7) into [master](https://codecov.io/gh/apache/arrow/commit/1393188e1aa1b3d59993ce7d4ade7f7ac8570959?el=desc) (1393188) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow/pull/9222?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9222 +/- ##
==========================================
- Coverage 81.61% 81.61% -0.01%
==========================================
Files 215 215
Lines 51867 51860 -7
==========================================
- Hits 42329 42323 -6
+ Misses 9538 9537 -1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9222?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/parquet/src/arrow/arrow\_writer.rs](https://codecov.io/gh/apache/arrow/pull/9222/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9hcnJvd193cml0ZXIucnM=) | `95.73% <100.00%> (+0.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9222?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9222?src=pr&el=footer). Last update [eaa7b7a...daaf2a7](https://codecov.io/gh/apache/arrow/pull/9222?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] TurnOfACard commented on pull request #9222: ARROW-11279: [Rust][Parquet] ArrowWriter Definition Levels Memory Usage
Posted by GitBox <gi...@apache.org>.
TurnOfACard commented on pull request #9222:
URL: https://github.com/apache/arrow/pull/9222#issuecomment-761746132
That should have been updated now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org