[jira] [Commented] (FLINK-18479) can not commit partition when set partition time

["Jingsong Lee (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-18479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233221#comment-17233221 ] 

Jingsong Lee commented on FLINK-18479:
--------------------------------------

Hi [~zhangjun], I replied you in the PR, I think this ticket is not a valid bug, I will close it.

If you have question, feel free to at me.

> can not commit partition when set partition time
> ------------------------------------------------
>
>                 Key: FLINK-18479
>                 URL: https://issues.apache.org/jira/browse/FLINK-18479
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / Runtime
>    Affects Versions: 1.11.0
>            Reporter: Jun Zhang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.12.0, 1.11.3
>
>
> when we write streaming data to filesystem, and select the 'partition time' , we can not commit the partition when write finished.
>  
> {code:java}
> LocalDateTime partTime = extractor.extract(
>       partitionKeys, extractPartitionValues(new Path(partition)));
> if (watermark > toMills(partTime) + commitDelay) {
>    needCommit.add(partition);
>    iter.remove();
> }
> {code}
> when we set a not UTC zone, and submit the partition, the method 'toMills' will get the UTC mills ，for example ，in UTC/GMT+08:00 ，the watermark will less than the toMills , so we can not commit the partition forever.
> if we use a local time , not utc , it will be ok in UTC zone and other zone.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)