You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/07 16:13:10 UTC

[GitHub] [fineract] ptuomola commented on pull request #989: FINERACT-822 enable MissingCasesInEnumSwitch error

ptuomola commented on pull request #989:
URL: https://github.com/apache/fineract/pull/989#issuecomment-640242074


   I would have the same concern as @vorburger: my understanding was that the warning was correctly stating that some cases are not handled. Adding a default case will of course make the warning shut up, but do we know if a "no action" default results in the right handling for all the missing cases? 
   
   Even if "do nothing" is the right behaviour for the missing cases, I'd still recommend adding those cases explicitly to the switch statement. That way if someone adds more values for the enum, they are forced to consider what would be the right behaviour for the new values...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org