You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@aurora.apache.org by ke...@apache.org on 2014/12/19 21:35:07 UTC
incubator-aurora git commit: Remove unused 3rdparty dependencies.
Wire up tests not linked to src/test/python:all Remove unused tests.
Repository: incubator-aurora
Updated Branches:
refs/heads/master 9042c56a3 -> 393b2a30a
Remove unused 3rdparty dependencies.
Wire up tests not linked to src/test/python:all
Remove unused tests.
Testing Done:
Listed leaf dependencies:
```bash
for target in $(./pants goal list :: 2>/dev/null); do
if [[ -z "$(./pants goal dependees $target 2>/dev/null)" ]]; then
echo $target
fi
done
```
Reviewed at https://reviews.apache.org/r/29267/
Project: http://git-wip-us.apache.org/repos/asf/incubator-aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-aurora/commit/393b2a30
Tree: http://git-wip-us.apache.org/repos/asf/incubator-aurora/tree/393b2a30
Diff: http://git-wip-us.apache.org/repos/asf/incubator-aurora/diff/393b2a30
Branch: refs/heads/master
Commit: 393b2a30aadd58eb17b09b7932b7ae4e0b32d1ad
Parents: 9042c56
Author: Kevin Sweeney <ke...@apache.org>
Authored: Fri Dec 19 12:23:26 2014 -0800
Committer: Kevin Sweeney <ke...@apache.org>
Committed: Fri Dec 19 12:23:26 2014 -0800
----------------------------------------------------------------------
3rdparty/python/requirements.txt | 3 --
src/test/python/apache/aurora/client/BUILD | 1 +
src/test/python/apache/aurora/executor/BUILD | 6 ---
.../python/apache/aurora/executor/common/BUILD | 1 +
.../aurora/executor/test_executor_builds.py | 43 --------------------
5 files changed, 2 insertions(+), 52 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/393b2a30/3rdparty/python/requirements.txt
----------------------------------------------------------------------
diff --git a/3rdparty/python/requirements.txt b/3rdparty/python/requirements.txt
index 9d9e966..05bbf33 100644
--- a/3rdparty/python/requirements.txt
+++ b/3rdparty/python/requirements.txt
@@ -13,8 +13,6 @@ thrift==0.9.1
twitter.common.app==0.3.2
twitter.common.collections==0.3.2
twitter.common.concurrent==0.3.2
-twitter.common.config==0.3.2
-twitter.common.confluence==0.3.2
twitter.common.contextutil==0.3.2
twitter.common.decorators==0.3.2
twitter.common.dirutil==0.3.2
@@ -31,6 +29,5 @@ twitter.common.recordio==0.3.2
twitter.common.rpc==0.3.2
twitter.common.string==0.3.2
twitter.common.testing==0.3.2
-twitter.common.util==0.3.2
twitter.common.zookeeper==0.3.2
watchdog==0.7.0
http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/393b2a30/src/test/python/apache/aurora/client/BUILD
----------------------------------------------------------------------
diff --git a/src/test/python/apache/aurora/client/BUILD b/src/test/python/apache/aurora/client/BUILD
index e31e434..e40c7a6 100644
--- a/src/test/python/apache/aurora/client/BUILD
+++ b/src/test/python/apache/aurora/client/BUILD
@@ -14,6 +14,7 @@
python_test_suite(name = 'all',
dependencies = [
+ ':base',
':binding_helper',
':config',
'src/test/python/apache/aurora/client/api:all',
http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/393b2a30/src/test/python/apache/aurora/executor/BUILD
----------------------------------------------------------------------
diff --git a/src/test/python/apache/aurora/executor/BUILD b/src/test/python/apache/aurora/executor/BUILD
index 3095f2a..aa3bc3b 100644
--- a/src/test/python/apache/aurora/executor/BUILD
+++ b/src/test/python/apache/aurora/executor/BUILD
@@ -36,8 +36,6 @@ python_test_suite(
python_test_suite(
name = 'executor-large',
dependencies = [
- # TODO(jfarrell): AURORA-14 for executor_builds
- #':executor_builds',
':gc_executor',
':thermos_executor',
]
@@ -132,7 +130,3 @@ python_tests(name = 'executor_vars',
'src/main/python/apache/aurora/executor:executor_vars',
]
)
-
-python_tests(name = 'executor_builds',
- sources = ['test_executor_builds.py'],
-)
http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/393b2a30/src/test/python/apache/aurora/executor/common/BUILD
----------------------------------------------------------------------
diff --git a/src/test/python/apache/aurora/executor/common/BUILD b/src/test/python/apache/aurora/executor/common/BUILD
index 4fa80b8..2bf6b2d 100644
--- a/src/test/python/apache/aurora/executor/common/BUILD
+++ b/src/test/python/apache/aurora/executor/common/BUILD
@@ -19,6 +19,7 @@ python_test_suite(
':directory_sandbox',
':executor_timeout',
':health_checker',
+ ':kill_manager',
':status_checker',
':task_info',
]
http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/393b2a30/src/test/python/apache/aurora/executor/test_executor_builds.py
----------------------------------------------------------------------
diff --git a/src/test/python/apache/aurora/executor/test_executor_builds.py b/src/test/python/apache/aurora/executor/test_executor_builds.py
deleted file mode 100644
index be6800f..0000000
--- a/src/test/python/apache/aurora/executor/test_executor_builds.py
+++ /dev/null
@@ -1,43 +0,0 @@
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-import subprocess
-
-import pytest
-
-
-def build_and_execute_pex_target(target, binary):
- assert subprocess.call(["./pants", target]) == 0
-
- # TODO(wickman) Should we extract distdir from pants.ini?
- po = subprocess.Popen([binary, "--help"], stderr=subprocess.STDOUT, stdout=subprocess.PIPE)
- so, se = po.communicate()
- assert po.returncode == 1 # sigh
- assert so.startswith('Options'), 'Unexpected build output: %s' % so
-
-
-# TODO(ksweeney): Unignore when mesos.native is pip-installable
-# (https://issues.apache.org/jira/browse/MESOS-684).
-@pytest.mark.skipif("True")
-def test_thermos_executor_build():
- build_and_execute_pex_target('src/main/python/apache/aurora/executor/bin:thermos_executor',
- 'dist/thermos_executor.pex')
-
-
-# TODO(ksweeney): Unignore when mesos.native is pip-installable
-# (https://issues.apache.org/jira/browse/MESOS-684).
-@pytest.mark.skipif("True")
-def test_gc_executor_build():
- build_and_execute_pex_target('src/main/python/apache/aurora/executor/bin:gc_executor',
- 'dist/gc_executor.pex')