[GitHub] [skywalking] lujiajing1126 edited a comment on issue #7082: Inaccurate database metrics due to Sharding JDBC plugin

[GitBox <gi...@apache.org>]

lujiajing1126 edited a comment on issue #7082:
URL: https://github.com/apache/skywalking/issues/7082#issuecomment-856629364


   > > In some of our business units, they are using Skywalking and want to have a dashboard for SQL(s) metrics.
   > 
   > But we don't have anything on upstream, so where could we start to discuss? If this is something not existing in open source, or accepted by the community.
   > 
   > > But traces cannot provide aggregational information like percentiles...
   > 
   > Again, no use case for upsteam. We can't discuss a thing not existing in public.
   
   Maybe the original description by the author is somehow confusing.
   
   We do have original SQL (formal one) as a Tag in the Local Span so far, (`/ShardingSphere/ParseSQL` below)
   
   ![image](https://user-images.githubusercontent.com/2568208/121163025-0713b300-c881-11eb-9fcb-c6dc12572511.png)
   
   The problem is that the LocalSpan (`/ShardingSphere/ParseSQL` in the figure) does not represent/carry any real execution information, for example, we cannot get real latency for this span and this also cannot be connected to the "MySQL/JDBC/Statement/executeQuery" span below.
   
   So the only issue we want to discuss here is whether it is possible to duplicate or move the tag (`db.statement` in `/ShardingSphere/ParseSQL`) to the `/ShardingSphere/executeSQL/` span.
   
   For the OAL and user-defined metrics, users can always write OAL to generate new metrics and add them to the Skywalking dashboard, right?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org