[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3759: into_inner() for CSV Writer

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #3759:
URL: https://github.com/apache/arrow-rs/pull/3759#discussion_r1117954790


##########
arrow-csv/src/writer.rs:
##########
@@ -185,6 +185,11 @@ impl<W: Write> Writer<W> {
 
         Ok(())
     }
+
+    /// Unwraps this `Writer<W>`, returning the underlying writer
+    pub fn into_inner(self) -> W {
+        self.writer.into_inner().unwrap()

Review Comment:
   Perhaps a comment here saying the unwrap is fine because write always flushes, assuming that is actually the case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org