You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/09 04:43:06 UTC
[GitHub] [shardingsphere] azexcy opened a new pull request, #17469: Fix execute in different schema of query oid
azexcy opened a new pull request, #17469:
URL: https://github.com/apache/shardingsphere/pull/17469
Changes proposed in this pull request:
- Fix execute in different schema of query oid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz merged pull request #17469: Use PipelineDDLGenerator to generate postgres ddl
Posted by GitBox <gi...@apache.org>.
sandynz merged PR #17469:
URL: https://github.com/apache/shardingsphere/pull/17469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] azexcy commented on a diff in pull request #17469: Use PipelineDDLGenerator to generate postgres ddl
Posted by GitBox <gi...@apache.org>.
azexcy commented on code in PR #17469:
URL: https://github.com/apache/shardingsphere/pull/17469#discussion_r868758326
##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-scaling/src/test/java/org/apache/shardingsphere/integration/data/pipeline/framework/container/proxy/ShardingSphereProxyDockerContainer.java:
##########
@@ -51,15 +51,15 @@ protected void configure() {
} else {
setWaitStrategy(new JDBCConnectionWaitStrategy(() -> DriverManager.getConnection(DataSourceEnvironment.getURL(databaseType, getHost(), getMappedPort(3307), ""), "root", "root")));
}
- withLogConsumer(new Slf4jLogConsumer(log));
+ withLogConsumer(new Slf4jLogConsumer(log).withSeparateOutputStreams());
Review Comment:
default docker log level is INFO(Even if it is error)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on a diff in pull request #17469: Use PipelineDDLGenerator to generate postgres ddl
Posted by GitBox <gi...@apache.org>.
sandynz commented on code in PR #17469:
URL: https://github.com/apache/shardingsphere/pull/17469#discussion_r868763636
##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-scaling/src/test/java/org/apache/shardingsphere/integration/data/pipeline/cases/BaseITCase.java:
##########
@@ -159,6 +161,7 @@ protected void checkMatchConsistency(final JdbcTemplate jdbcTemplate, final Stri
Map<String, String> actualStatusMap = new HashMap<>(2, 1);
for (int i = 0; i < 100; i++) {
List<Map<String, Object>> showScalingStatusResMap = jdbcTemplate.queryForList(String.format("SHOW SCALING STATUS %s", jobId));
+ log.warn("actualStatusMap: {}", actualStatusMap);
Review Comment:
It could be `info` for integration test logback-test.xml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #17469: Use PipelineDDLGenerator to generate postgres ddl
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #17469:
URL: https://github.com/apache/shardingsphere/pull/17469#issuecomment-1121743977
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17469?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17469](https://codecov.io/gh/apache/shardingsphere/pull/17469?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a775c9f) into [master](https://codecov.io/gh/apache/shardingsphere/commit/0a5329c785297a96036024a5255d5dfdd2dfdc79?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0a5329c) will **increase** coverage by `0.10%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #17469 +/- ##
============================================
+ Coverage 59.06% 59.17% +0.10%
Complexity 2122 2122
============================================
Files 3558 3558
Lines 53121 53025 -96
Branches 9068 9044 -24
============================================
Hits 31377 31377
+ Misses 19095 18999 -96
Partials 2649 2649
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/17469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...epare/datasource/PostgreSQLDataSourcePreparer.java](https://codecov.io/gh/apache/shardingsphere/pull/17469/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1kaWFsZWN0L3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9wb3N0Z3Jlc3FsL3ByZXBhcmUvZGF0YXNvdXJjZS9Qb3N0Z3JlU1FMRGF0YVNvdXJjZVByZXBhcmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...resql/sqlbuilder/PostgreSQLPipelineSQLBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/17469/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1kaWFsZWN0L3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9wb3N0Z3Jlc3FsL3NxbGJ1aWxkZXIvUG9zdGdyZVNRTFBpcGVsaW5lU1FMQnVpbGRlci5qYXZh) | `94.73% <0.00%> (ø)` | |
| [...ta/pipeline/postgresql/util/FreemarkerManager.java](https://codecov.io/gh/apache/shardingsphere/pull/17469/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1kaWFsZWN0L3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9wb3N0Z3Jlc3FsL3V0aWwvRnJlZW1hcmtlck1hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17469?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17469?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0a5329c...a775c9f](https://codecov.io/gh/apache/shardingsphere/pull/17469?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on a diff in pull request #17469: Use PipelineDDLGenerator to generate postgres ddl
Posted by GitBox <gi...@apache.org>.
sandynz commented on code in PR #17469:
URL: https://github.com/apache/shardingsphere/pull/17469#discussion_r868763851
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-dialect/shardingsphere-data-pipeline-postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/sqlbuilder/PostgreSQLPipelineSQLBuilder.java:
##########
@@ -33,7 +33,8 @@ public final class PostgreSQLPipelineSQLBuilder extends AbstractPipelineSQLBuild
@Override
public String buildCreateSchemaSQL(final String schemaName) {
- return "CREATE SCHEMA IF NOT EXISTS " + quote(schemaName);
+ // TODO remove first, add when kernel fixed bug.
+ return "CREATE SCHEMA IF NOT EXISTS " + schemaName;
Review Comment:
`quote(schemaName)` could be recovered since it's fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on a diff in pull request #17469: Use PipelineDDLGenerator to generate postgres ddl
Posted by GitBox <gi...@apache.org>.
sandynz commented on code in PR #17469:
URL: https://github.com/apache/shardingsphere/pull/17469#discussion_r868764312
##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-scaling/src/test/resources/env/logback.xml:
##########
@@ -22,12 +22,12 @@
<pattern>[%-5level] %d{yyyy-MM-dd HH:mm:ss.SSS} [%thread] %logger{36} - %msg%n</pattern>
</encoder>
</appender>
- <logger name="org.apache.shardingsphere" level="error" additivity="false">
+ <logger name="org.apache.shardingsphere" level="warn" additivity="false">
Review Comment:
Log level could uppercase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on a diff in pull request #17469: Use PipelineDDLGenerator to generate postgres ddl
Posted by GitBox <gi...@apache.org>.
sandynz commented on code in PR #17469:
URL: https://github.com/apache/shardingsphere/pull/17469#discussion_r868764134
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-dialect/shardingsphere-data-pipeline-postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/util/FreemarkerManager.java:
##########
@@ -72,7 +70,7 @@ public static FreemarkerManager getInstance() {
@SneakyThrows
private Configuration createTemplateConfiguration() {
Configuration result = new Configuration(Configuration.VERSION_2_3_31);
- result.setDirectoryForTemplateLoading(new File(Objects.requireNonNull(FreemarkerManager.class.getClassLoader().getResource("template")).getFile()));
+ result.setClassForTemplateLoading(this.getClass(), "/template");
Review Comment:
`this.getClass()` could be simplified to `getClass()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org