Re: [PR] feat: add IcebergCatalogTableProvider::new_with_schema [datafusion-iceberg]

["gabotechs (via GitHub)" <gi...@apache.org>]

gabotechs commented on PR #48:
URL: https://github.com/apache/datafusion-iceberg/pull/48#issuecomment-6106474174

   Just merged #18! about the snapshot testing, DataFusion uses `insta` (https://datafusion.apache.org/contributor-guide/testing.html#snapshot-testing-cargo-insta), which is similar to `expect-test` but with some more features.
   
   For consistency with Apache DataFusion, I think we should move this project out of `expect-test` into `insta`. DataFusion contributors will be more familiar with that tool, and we'll bridge a bit the gap between the testing approaches in both projects.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org