[GitHub] [cloudstack] davidjumani commented on a change in pull request #4459: createkubertetesbinariesiso: Saving images in network and dashboard yaml

[GitBox <gi...@apache.org>]

davidjumani commented on a change in pull request #4459:
URL: https://github.com/apache/cloudstack/pull/4459#discussion_r525994168



##########
File path: scripts/util/create-kubernetes-binaries-iso.sh
##########
@@ -87,6 +91,14 @@ if [ $? -ne 0 ]; then
 fi
 mkdir -p "${working_dir}/docker"
 output=`${k8s_dir}/kubeadm config images list --kubernetes-version=${RELEASE}`
+
+# Don't forget about the yaml images !
+for i in ${network_conf_file} ${dashboard_conf_file}
+do
+  images=`grep "image:" $i | cut -d ':' -f2- | tr -d ' ' | tr -d "'"`
+  output=`printf "%s\n" ${output} ${images}`

Review comment:
       It's a simpler way of doing `printf "%s\n%s\n" ${output} ${images}` :D




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org