You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/22 12:47:26 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #24759: [SPARK-27395][SQL] Improve EXPLAIN command

cloud-fan commented on a change in pull request #24759: [SPARK-27395][SQL] Improve EXPLAIN command
URL: https://github.com/apache/spark/pull/24759#discussion_r316657745
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala
 ##########
 @@ -77,6 +77,15 @@ case class ReusedExchangeExec(override val output: Seq[Attribute], child: Exchan
   override def outputOrdering: Seq[SortOrder] = {
     child.outputOrdering.map(updateAttr(_).asInstanceOf[SortOrder])
   }
+
+  override def verboseStringWithOperatorId(): String = {
+    val cdgen = ExplainUtils.getCodegenId(this)
+    val reuse_op_str = ExplainUtils.getOpId(child)
+    s"""
+       |(${ExplainUtils.getOpId(this)}) $nodeName ${cdgen} [Reuses operator id: $reuse_op_str]
 
 Review comment:
   So we don't print the query plan for subquery 2. How is it implemented?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org