[GitHub] [couchdb] bessbd commented on issue #2338: Allow all params to be passed via body for POST view

[GitBox <gi...@apache.org>]

bessbd commented on issue #2338: Allow all params to be passed via body for POST view
URL: https://github.com/apache/couchdb/pull/2338#issuecomment-560449984
 
 
   > @bessbd Thanks for the PR! The general idea here is fine but its not going to be acceptable to drop the query string parameters. Reading through this I think the best approach would be to add an option in `couch_mrview_http:parse_params/4` that disables reseting the group/group_level properties in the provided `#mrargs{}` record and then you'd just call that function twice. First for the body then the query string parameters (so that query string parameters override the body to maintain the current behavior).
   > 
   > Let me know if you need any pointers on that approach or find any issues with it.
   
   Thank you for the review and the suggestion, @davisp ! I think I'll have a commit pushed for that in about 24 hours.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services