[jira] Closed: (WICKET-1233) getMarkupSettings().setStripComments() is stripping too much

["Peter Ertl (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl closed WICKET-1233.
------------------------------


> getMarkupSettings().setStripComments() is stripping too much
> ------------------------------------------------------------
>
>                 Key: WICKET-1233
>                 URL: https://issues.apache.org/jira/browse/WICKET-1233
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Peter Ertl
>            Assignee: Juergen Donnerstag
>
> I suppose stripComments()'s main purpose is to remove developers comments from the markup source. However, it's not only removing
>  <!-- comments -->
> but also Microsoft Internet Explorers conditional comments which are, well, err, not exactly the same as traditional comments, if you ask me...
> I guess most developers will agree it's better to _not_ remove comments like
>   <!--[if IE]> 
>     <link rel="stylesheet" type="text/css" href="explorer_bugs.css"/>
>   -->
> Maybe it's worth an extra settings setStripConditionalComments() ?!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.