You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@tajo.apache.org by dkhwangbo <gi...@git.apache.org> on 2016/01/14 11:42:13 UTC

[GitHub] tajo pull request: TAJO-2053: Update description for HBase configu...

GitHub user dkhwangbo opened a pull request:

    https://github.com/apache/tajo/pull/941

    TAJO-2053: Update description for HBase configuration.

    I replace hbase:// with hbase:zk:// in tablesapce doc. Also, I add some trivia comment about HBase setting in Hbase_integration doc.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dkhwangbo/tajo TAJO-2053

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/941.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #941
    
----
commit eb4c31062239f56c914b7b5575d79f44ccef03e5
Author: Dongkyu Hwangbo <hw...@gmail.com>
Date:   2016-01-14T10:37:46Z

    initial commit

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-2053: Update description for HBase configu...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/941


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-2053: Update description for HBase configu...

Posted by blrunner <gi...@git.apache.org>.

Github user blrunner commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/941#discussion_r49942345
  
    --- Diff: tajo-docs/src/main/sphinx/hbase_integration.rst ---
    @@ -94,7 +99,8 @@ In order to create a new HBase table which is to be managed by Tajo, use the USI
       CREATE EXTERNAL TABLE blog (rowkey text, author text, register_date text, title text)
       USING hbase WITH (
         'table'='blog'
    -    , 'columns'=':key,info:author,info:date,content:title');
    +    , 'columns'=':key,info:author,info:date,content:title')
    +  LOCATION 'hbase:zk://localhost:2181/';
    --- End diff --
    
    We need to specify general environment. So, you need to use ``<hostname>`` instead of ``localhost`` and ``<port>`` instead of ``2181``.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-2053: Update description for HBase configu...

Posted by blrunner <gi...@git.apache.org>.

Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/941#issuecomment-172406899
  
    +1
    
    Thank you for your contribution. I'll ship it soon. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-2053: Update description for HBase configu...

Posted by dkhwangbo <gi...@git.apache.org>.

Github user dkhwangbo commented on the pull request:

    https://github.com/apache/tajo/pull/941#issuecomment-172298190
  
    @blrunner Thanks for your reply. I rewrite the line you mentioned. Please review it again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---