[GitHub] [kafka] divijvaidya commented on pull request #13619: Initial support for OpenJDK CRaC snapshotting

["divijvaidya (via GitHub)" <gi...@apache.org>]

divijvaidya commented on PR #13619:
URL: https://github.com/apache/kafka/pull/13619#issuecomment-1516093525

   Hi @rvansa 
   Thank you for your first contribution to Apache Kafka! Thanks to you, today I learnt something new (CRaC). 
   
   For an effective discussion on this topic, starting a discussion thread with the community at dev@kafka.apache.org (preferably accompanied with a KIP)? I am asking for this because we need to dig more into the problem that this is solving for us, alternative solutions and weigh the tradeoffs of using a non-GA feature of OpenJDK (and I understand that you have tried to address this using the facade package). You can find the process of creating a KIP at https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals 
   
   My initial thoughts (based on limited understanding, please correct me if I am wrong):
   - What is the downside of adding checkpoint & restore to the producer threads? What expense does it add?
   - Looks like we are trying to save resource by suspending the threads (on the producer) that are not actively doing anything and restoring them when we they are needed? Is that right? 
   
   Let's talk more on the mailing list.
   
   > It is not entirely clear to me what level of API publicity are the KafkaClient and Selectable interface
   
   In general, you can find all public APIs for Kafka at https://kafka.apache.org/34/javadoc/allclasses-index.html 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org