Re: Problem renaming existing file in FTP

[mikaelfj <mi...@gmail.com>]

Hi,

Got a chance to look into this again.

We still have the problem described, but just on a few destination servers
which all seems to be windows machines(?).

I have fetched the 2.4 branch of camel-ftp to find out why it does not work,
since the unit test you refer to in your previous post do excercise the
problem.

It appears that the cause of the problem is, that the
FtpOperations.existsFile fails to return true, which then causes the code
not to enter the part where it deletes the exisiting file.

The reason for the FtpOperations.existsFile to return false, is, that the
list of existing files has the directoryname prepended, e.g. I'm trying to
upload Test.REN to folder test/rename, and in the code 
"if (existing.equals(onlyName))" 
existing=test/rename\Test.REN and onlyName=Test.REN - which returns false -
but causes the later rename to fail as the target folder did contain the
Test.REN. 

My guess is that it is server dependent whether the returned list of names
in the directory include the directory name or not?

To fix this I have added the following line of code before the if-statement
existing = FileUtil.stripPath(FileUtil.normalizePath(existing));
So it will strip the path part of the file name before comparing it to
onlyName.

I've added a jira for this
(https://issues.apache.org/jira/browse/CAMEL-3595), including a patch.

Regards 
Mikael
-- 
View this message in context: http://camel.465427.n5.nabble.com/Problem-renaming-existing-file-in-FTP-tp3307670p3359761.html
Sent from the Camel - Users mailing list archive at Nabble.com.

Re: Problem renaming existing file in FTP

[mikaelfj <mi...@gmail.com>]

Hi,

Hmmm - we found that this doesn't work when camel is runing on unix and the
ftp-server is windows:

If existing is aa/bb/cc\test.txt and OS (where camel runs) is windows then  
normalizePath(existing) = aa\bb\cc\test.txt (i.e. fil separators are
normalized)
and stripPath(normalizePath(existing)) = test.txt (it takes substring after
last position of / or File.separator=\)

If existing is aa/bb/cc\test.txt and OS (where camel runs) is NOT windows
then 
normalizePath(existing) = aa/bb/cc\test.txt (i.e. unchanged)
og stripPath(normalizePath(existing)) = Test\test.txt (it takes substring
after last position of / or File.separator=\)

Instead we are now using the following method added to the FtpOperations - 

    // Will return substring from last occurence of either / or \ - works as
long as / or \ are not part of the file name
    public static String onlyFileName(String name){
    	char unixSep = '/';
    	char winSep = '\\';
        if (name == null) {
            return null;
        }
        int unixPos = name.lastIndexOf(unixSep);
        int winPos = name.lastIndexOf(winSep);
        if (unixPos > winPos) {
            return name.substring(unixPos + 1);
        }
        if (winPos > unixPos) {
            return name.substring(winPos + 1);
        }
        return name;
    }

I have updated the jira-issue accordingly.

Regards
Mikael
-- 
View this message in context: http://camel.465427.n5.nabble.com/Problem-renaming-existing-file-in-FTP-tp3307670p3363358.html
Sent from the Camel - Users mailing list archive at Nabble.com.