You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "dragon512 (via GitHub)" <gi...@apache.org> on 2023/02/10 19:49:23 UTC

[GitHub] [trafficserver] dragon512 commented on a diff in pull request #9397: Remove absolute libswoc include paths.

dragon512 commented on code in PR #9397:
URL: https://github.com/apache/trafficserver/pull/9397#discussion_r1103169755


##########
build/libswoc.m4:
##########
@@ -51,26 +51,29 @@ AC_ARG_WITH(libswoc, [AS_HELP_STRING([--with-libswoc=DIR],[use a specific libswo
     AC_MSG_RESULT([not found])
   fi
 
-if test "$has_libswoc" != "no"; then
-  saved_ldflags=$LDFLAGS
-  saved_cppflags=$CPPFLAGS
+  if test "$has_libswoc" != "no"; then
+    saved_ldflags=$LDFLAGS
+    saved_cppflags=$CPPFLAGS
 
-  SWOC_LIBS=-ltsswoc
-  if test "$libswoc_base_dir" != "/usr"; then
-    SWOC_INCLUDES=-I${swoc_include}
-    SWOC_LDFLAGS=-L${swoc_ldflags}
+    SWOC_LIBS=-lswoc

Review Comment:
   Can this value be set via the pkg-config file instead??



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org