You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/07/30 15:11:40 UTC
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #11213: [Improvement-10760][dolphinscheduler-api] Some variables are redundant and fix checkstyle
caishunfeng commented on code in PR #11213:
URL: https://github.com/apache/dolphinscheduler/pull/11213#discussion_r933824131
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/UsersServiceImpl.java:
##########
@@ -455,60 +455,60 @@ public Map<String, Object> updateUser(User loginUser, int userId,
user.setUpdateTime(now);
//if user switches the tenant, the user's resources need to be copied to the new tenant
-// if (user.getTenantId() != tenantId) {
-// Tenant oldTenant = tenantMapper.queryById(user.getTenantId());
-// //query tenant
-// Tenant newTenant = tenantMapper.queryById(tenantId);
-// // if hdfs startup
-// if (null != newTenant && PropertyUtils.getResUploadStartupState() && oldTenant != null) {
-// String newTenantCode = newTenant.getTenantCode();
-// String oldResourcePath = storageOperate.getResDir(oldTenant.getTenantCode());
-// String oldUdfsPath = storageOperate.getUdfDir(oldTenant.getTenantCode());
-//
-// try {// if old tenant dir exists
-// if (storageOperate.exists(oldTenant.getTenantCode(), oldResourcePath)) {
-// String newResourcePath = storageOperate.getResDir(newTenantCode);
-// String newUdfsPath = storageOperate.getUdfDir(newTenantCode);
-//
-// //file resources list
-// List<Resource> fileResourcesList = resourceMapper.queryResourceList(
-// null, userId, ResourceType.FILE.ordinal());
-// if (CollectionUtils.isNotEmpty(fileResourcesList)) {
-// ResourceTreeVisitor resourceTreeVisitor = new ResourceTreeVisitor(fileResourcesList);
-// ResourceComponent resourceComponent = resourceTreeVisitor.visit();
-// copyResourceFiles(oldTenant.getTenantCode(), newTenantCode, resourceComponent, oldResourcePath, newResourcePath);
-// }
-//
-// //udf resources
-// List<Resource> udfResourceList = resourceMapper.queryResourceList(
-// null, userId, ResourceType.UDF.ordinal());
-// if (CollectionUtils.isNotEmpty(udfResourceList)) {
-// ResourceTreeVisitor resourceTreeVisitor = new ResourceTreeVisitor(udfResourceList);
-// ResourceComponent resourceComponent = resourceTreeVisitor.visit();
-// copyResourceFiles(oldTenant.getTenantCode(), newTenantCode, resourceComponent, oldUdfsPath, newUdfsPath);
-// }
-//
-// } else {
-// // if old tenant dir not exists , create
-// storageOperate.createTenantDirIfNotExists(oldTenant.getTenantCode());
-//
-// if (!storageOperate.exists(newTenant.getTenantCode(), storageOperate.getDir(null,newTenant.getTenantCode()))) {
-// storageOperate.createTenantDirIfNotExists(newTenant.getTenantCode());
-// }
-// }
-// } catch (Exception e) {
-// logger.error("create tenant {} failed ,the reason is {}", oldTenant, e.getMessage());
-// }
-//
-//
-// try {
-// storageOperate.createTenantDirIfNotExists(newTenant.getTenantCode());
-// } catch (Exception e) {
-// logger.error("create tenant {} failed ,the reason is {}", newTenant, e.getMessage());
-// }
-// }
-// user.setTenantId(tenantId);
-// }
+ // if (user.getTenantId() != tenantId) {
Review Comment:
please remove if not use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org