You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/06/10 15:23:17 UTC

[GitHub] [submarine] Kenchu123 opened a new pull request #603: SUBMARINE-850. Add operator e2e test framework

Kenchu123 opened a new pull request #603:
URL: https://github.com/apache/submarine/pull/603


   ### What is this PR for?
   
   Setup operator e2e test framework
   Reference: [spark-on-k8s-operator](https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/tree/master/test/e2e)
   
   ### What type of PR is it?
   
   Feature
   
   ### Todos
   
   * [ ] - Submarine test case
   
   ### What is the Jira issue?
   
   https://issues.apache.org/jira/browse/SUBMARINE-850
   
   ### How should this be tested?
   
   ```bash
   # Step1: Build image "submarine-operator" to minikube's Docker 
   eval $(minikube docker-env)
   make image
   
   # Step2: Register Custom Resource Definition
   kubectl apply -f artifacts/examples/crd.yaml
   
   # Step3: Install go module
   cd ./test/e2e
   go mod tidy
   
   # Step4: Run test
   go test
   ```
   
   ### Screenshots (if appropriate)
   
   https://user-images.githubusercontent.com/17617373/121552095-c2377a00-ca42-11eb-967e-263e6a7734a9.mov
   
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] Kenchu123 closed pull request #603: SUBMARINE-850. Add operator e2e test framework

Posted by GitBox <gi...@apache.org>.
Kenchu123 closed pull request #603:
URL: https://github.com/apache/submarine/pull/603


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] Kenchu123 commented on pull request #603: SUBMARINE-850. Add operator e2e test framework

Posted by GitBox <gi...@apache.org>.
Kenchu123 commented on pull request #603:
URL: https://github.com/apache/submarine/pull/603#issuecomment-873380572


   > @xunliu This PR is a test framework for Submarine operator. To elaborate, it implements hooks which are similar to `@BeforeClass` and `@AfterClass` in JUnit. In addition, this PR still needs to be updated due to the modification in [SUBMARINE-848](https://issues.apache.org/jira/browse/SUBMARINE-848) ([PR](https://github.com/apache/submarine/pull/606)).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #603: SUBMARINE-850. Add operator e2e test framework

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #603:
URL: https://github.com/apache/submarine/pull/603


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] Kenchu123 removed a comment on pull request #603: SUBMARINE-850. Add operator e2e test framework

Posted by GitBox <gi...@apache.org>.
Kenchu123 removed a comment on pull request #603:
URL: https://github.com/apache/submarine/pull/603#issuecomment-873380572


   > @xunliu This PR is a test framework for Submarine operator. To elaborate, it implements hooks which are similar to `@BeforeClass` and `@AfterClass` in JUnit. In addition, this PR still needs to be updated due to the modification in [SUBMARINE-848](https://issues.apache.org/jira/browse/SUBMARINE-848) ([PR](https://github.com/apache/submarine/pull/606)).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] Kenchu123 commented on pull request #603: SUBMARINE-850. Add operator e2e test framework

Posted by GitBox <gi...@apache.org>.
Kenchu123 commented on pull request #603:
URL: https://github.com/apache/submarine/pull/603#issuecomment-873567396


   @kevin85421  I have made change for [SUBMARINE-889](https://issues.apache.org/jira/browse/SUBMARINE-889)([PR](https://github.com/apache/submarine/commit/10a41504022c6158c19cbaf5d1292835806ed2e2))
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] Kenchu123 edited a comment on pull request #603: SUBMARINE-850. Add operator e2e test framework

Posted by GitBox <gi...@apache.org>.
Kenchu123 edited a comment on pull request #603:
URL: https://github.com/apache/submarine/pull/603#issuecomment-873567396


   @kevin85421  I have made change for [SUBMARINE-889](https://issues.apache.org/jira/browse/SUBMARINE-889)([PR](https://github.com/apache/submarine/commit/10a41504022c6158c19cbaf5d1292835806ed2e2)).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] kevin85421 commented on pull request #603: SUBMARINE-850. Add operator e2e test framework

Posted by GitBox <gi...@apache.org>.
kevin85421 commented on pull request #603:
URL: https://github.com/apache/submarine/pull/603#issuecomment-863716847


   @xunliu This PR is a test framework for Submarine operator. To elaborate, it implements hooks which are similar to `@BeforeClass` and `@AfterClass` in JUnit. In addition, this PR still needs to be updated due to the modification in SUBMARINE-848 ([PR](https://github.com/apache/submarine/pull/606)). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] Kenchu123 commented on pull request #603: SUBMARINE-850. Add operator e2e test framework

Posted by GitBox <gi...@apache.org>.
Kenchu123 commented on pull request #603:
URL: https://github.com/apache/submarine/pull/603#issuecomment-873380904


   @kevin85421  I have fixed the namespace for [SUBMARINE-848](https://issues.apache.org/jira/browse/SUBMARINE-848) ([PR](https://github.com/apache/submarine/pull/606)). Besides, I have edited the PR details, and added more helper functions in framework for further test case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org