You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "lincoln lee (Jira)" <ji...@apache.org> on 2021/10/27 08:38:00 UTC
[jira] [Updated] (FLINK-24666) The lenient option was not exposed
to users on RetractableTopNFunction
[ https://issues.apache.org/jira/browse/FLINK-24666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
lincoln lee updated FLINK-24666:
--------------------------------
Description:
Currently, the lenient option was not exposed to users on RetractableTopNFunction
{quote}// flag to skip records with non-exist error instead to fail, true by default.
private final boolean lenient = true
{quote}
So there's no chance to raise the exception when the record(s) unexpectedly cleared by state ttl (Commonly this happens because a too shorter ttl)
{quote}List<RowData> inputs = dataState.get(key);
if (inputs == null) {
// Skip the data if it's state is cleared because of state ttl.
if (lenient) {
LOG.warn(STATE_CLEARED_WARN_MSG);
} else {
throw new RuntimeException(STATE_CLEARED_WARN_MSG);
}
}{quote}
We'd better to expose it or completely resolve the inconsistenty problem between the two state:
{quote}// a map state stores mapping from sort key to records list
private transient MapState<RowData, List<RowData>> dataState;
// a sorted map stores mapping from sort key to records count
private transient ValueState<SortedMap<RowData, Long>> treeMap
{quote}
was:
Currently, the lenient option was not exposed to users on RetractableTopNFunction
{quote}// flag to skip records with non-exist error instead to fail, true by default.
private final boolean lenient = true{quote}
We'd better to expose it or completely resolve the inconsistenty problem between the two state:
{quote}// a map state stores mapping from sort key to records list
private transient MapState<RowData, List<RowData>> dataState;
// a sorted map stores mapping from sort key to records count
private transient ValueState<SortedMap<RowData, Long>> treeMap{quote}
> The lenient option was not exposed to users on RetractableTopNFunction
> ----------------------------------------------------------------------
>
> Key: FLINK-24666
> URL: https://issues.apache.org/jira/browse/FLINK-24666
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Runtime
> Affects Versions: 1.14.0, 1.13.3
> Reporter: lincoln lee
> Priority: Minor
> Fix For: 1.15.0
>
>
> Currently, the lenient option was not exposed to users on RetractableTopNFunction
> {quote}// flag to skip records with non-exist error instead to fail, true by default.
> private final boolean lenient = true
> {quote}
> So there's no chance to raise the exception when the record(s) unexpectedly cleared by state ttl (Commonly this happens because a too shorter ttl)
> {quote}List<RowData> inputs = dataState.get(key);
> if (inputs == null) {
> // Skip the data if it's state is cleared because of state ttl.
> if (lenient) {
> LOG.warn(STATE_CLEARED_WARN_MSG);
> } else {
> throw new RuntimeException(STATE_CLEARED_WARN_MSG);
> }
> }{quote}
> We'd better to expose it or completely resolve the inconsistenty problem between the two state:
> {quote}// a map state stores mapping from sort key to records list
> private transient MapState<RowData, List<RowData>> dataState;
> // a sorted map stores mapping from sort key to records count
> private transient ValueState<SortedMap<RowData, Long>> treeMap
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)