You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "haohao0103 (via GitHub)" <gi...@apache.org> on 2024/07/15 03:47:38 UTC

[PR] PD, Store process log files do not scrollclose #2581 [incubator-hugegraph]

haohao0103 opened a new pull request, #2589:
URL: https://github.com/apache/incubator-hugegraph/pull/2589

   close #2581 
   
   GRPC Java defaults to using java. til.rogging (JUL) as its logging framework,


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] fix(pd/store): log files do not scroll with the process [incubator-hugegraph]

Posted by "VGalaxies (via GitHub)" <gi...@apache.org>.
VGalaxies commented on PR #2589:
URL: https://github.com/apache/incubator-hugegraph/pull/2589#issuecomment-2238984104

   @haohao0103 Running the `start-hugegraph-pd.sh` script reports an error?
   
   ```text
    Error: Could not find or load main class .logging.log4j.jul.LogManager                                                                                                                                                                      
    Caused by: java.lang.ClassNotFoundException: /logging/log4j/jul/LogManager                                                                                                                                                                  
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] fix(pd/store): log files do not scroll with the process [incubator-hugegraph]

Posted by "VGalaxies (via GitHub)" <gi...@apache.org>.
VGalaxies commented on code in PR #2589:
URL: https://github.com/apache/incubator-hugegraph/pull/2589#discussion_r1681073760


##########
hugegraph-pd/hg-pd-dist/src/assembly/static/conf/log4j2.xml:
##########
@@ -129,7 +129,7 @@
         <!-- Use mixed async way to output logs -->
         <logger name="org.apache.hugegraph" level="INFO" additivity="false">
             <appender-ref ref="file" />
-            <appender-ref ref="console" />
+<!--            <appender-ref ref="console" />-->

Review Comment:
   Refer to the startup configuration of IDE for PD as follows:
   
   ```text
   -Dname=HugeGraphPD
   -Xms512m
   -Xmx6889m
   -XX:+HeapDumpOnOutOfMemoryError
   -XX:HeapDumpPath=/home/vgalaxies/Desktop/incubator-hugegraph/hugegraph-pd/apache-hugegraph-incubating-pd-1.5.0/logs
   -Dspring.config.location=/home/vgalaxies/Desktop/incubator-hugegraph/hugegraph-pd/apache-hugegraph-incubating-pd-1.5.0/conf/application.yml
   -Dlog4j.configurationFile=/home/vgalaxies/Desktop/incubator-hugegraph/hugegraph-pd/apache-hugegraph-incubating-pd-1.5.0/conf/log4j2.xml
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] fix(pd/store): log files do not scroll with the process [incubator-hugegraph]

Posted by "haohao0103 (via GitHub)" <gi...@apache.org>.
haohao0103 commented on PR #2589:
URL: https://github.com/apache/incubator-hugegraph/pull/2589#issuecomment-2241903008

   > @haohao0103 Running the `start-hugegraph-pd.sh` script reports an error?
   > 
   > ```
   >  Error: Could not find or load main class .logging.log4j.jul.LogManager                                                                                                                                                                      
   >  Caused by: java.lang.ClassNotFoundException: /logging/log4j/jul/LogManager                                                                                                                                                                  
   > ```
   # Turn on security check
   exec ${JAVA} -Dname="HugeGraphPD" ${JVM_OPTIONS} ${JAVA_OPTIONS} -jar \
       -Dspring.config.location=${CONF}/application.yml ${LIB}/hg-pd-service-*.jar >> ${OUTPUT} 2>&1 &
   
   According to this startup command, there needs to be hg-pd-service - *. jar in the lib directory. I guess the target dependency was not generated?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] fix(pd/store): log files do not scroll with the process [incubator-hugegraph]

Posted by "VGalaxies (via GitHub)" <gi...@apache.org>.
VGalaxies commented on PR #2589:
URL: https://github.com/apache/incubator-hugegraph/pull/2589#issuecomment-2245394845

   > > @haohao0103 Running the `start-hugegraph-pd.sh` script reports an error?
   > > ```
   > >  Error: Could not find or load main class .logging.log4j.jul.LogManager                                                                                                                                                                      
   > >  Caused by: java.lang.ClassNotFoundException: /logging/log4j/jul/LogManager                                                                                                                                                                  
   > > ```
   > 
   > exec ${JAVA} -Dname="HugeGraphPD" ${JVM_OPTIONS} ${JAVA_OPTIONS} -jar -Dspring.config.location=${CONF}/application.yml ${LIB}/hg-pd-service-*.jar >> ${OUTPUT} 2>&1 &
   > 
   > According to this startup command, there needs to be hg-pd-service - *. jar in the lib directory. I guess the target dependency was not generated?
   
   I discovered an unexpected line break...
   
   [`623ce53` (#2589)](https://github.com/apache/incubator-hugegraph/pull/2589/commits/623ce539e1ab52b7d52fc43dcefa73778eac28dc)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] PD, Store process log files do not scrollclose #2581 [incubator-hugegraph]

Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2589:
URL: https://github.com/apache/incubator-hugegraph/pull/2589#discussion_r1677375710


##########
hugegraph-pd/hg-pd-dist/src/assembly/static/conf/log4j2.xml:
##########
@@ -129,7 +129,7 @@
         <!-- Use mixed async way to output logs -->
         <logger name="org.apache.hugegraph" level="INFO" additivity="false">
             <appender-ref ref="file" />
-            <appender-ref ref="console" />
+<!--            <appender-ref ref="console" />-->

Review Comment:
   why we need disable the output to console?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] fix(pd/store): log files do not scroll with the process [incubator-hugegraph]

Posted by "VGalaxies (via GitHub)" <gi...@apache.org>.
VGalaxies commented on code in PR #2589:
URL: https://github.com/apache/incubator-hugegraph/pull/2589#discussion_r1681068414


##########
hugegraph-pd/hg-pd-dist/src/assembly/static/bin/start-hugegraph-pd.sh:
##########
@@ -159,8 +159,10 @@ if [ $(ps -ef|grep -v grep| grep java|grep -cE ${CONF}) -ne 0 ]; then
 fi
 echo "Starting HugeGraphPDServer..."
 
+JVM_OPTIONS="-Djava.util.logging.manager=org.apache.logging.log4j.jul.LogManager"

Review Comment:
   I found that pd here did not correctly configure the log4j file path...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] fix(pd/store): log files do not scroll with the process [incubator-hugegraph]

Posted by "haohao0103 (via GitHub)" <gi...@apache.org>.
haohao0103 commented on code in PR #2589:
URL: https://github.com/apache/incubator-hugegraph/pull/2589#discussion_r1682017976


##########
hugegraph-pd/hg-pd-dist/src/assembly/static/bin/start-hugegraph-pd.sh:
##########
@@ -159,8 +159,10 @@ if [ $(ps -ef|grep -v grep| grep java|grep -cE ${CONF}) -ne 0 ]; then
 fi
 echo "Starting HugeGraphPDServer..."
 
+JVM_OPTIONS="-Djava.util.logging.manager=org.apache.logging.log4j.jul.LogManager"

Review Comment:
   @VGalaxies  Do we need to unify? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] fix(pd/store): log files do not scroll with the process [incubator-hugegraph]

Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2589:
URL: https://github.com/apache/incubator-hugegraph/pull/2589#discussion_r1685481103


##########
hugegraph-pd/hg-pd-dist/src/assembly/static/conf/log4j2.xml:
##########
@@ -129,7 +129,7 @@
         <!-- Use mixed async way to output logs -->

Review Comment:
   > The comments here are somewhat outdated. I found that AsyncLogger is still being used in hugegraph-pd/hg-pd-service/src/main/resources/log4j2.xml. Any context @imbajin?
   
   maybe just due to (they) copy the config file from server?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] fix(pd/store): log files do not scroll with the process [incubator-hugegraph]

Posted by "VGalaxies (via GitHub)" <gi...@apache.org>.
VGalaxies commented on code in PR #2589:
URL: https://github.com/apache/incubator-hugegraph/pull/2589#discussion_r1681062295


##########
hugegraph-pd/hg-pd-dist/src/assembly/static/conf/log4j2.xml:
##########
@@ -129,7 +129,7 @@
         <!-- Use mixed async way to output logs -->
         <logger name="org.apache.hugegraph" level="INFO" additivity="false">
             <appender-ref ref="file" />
-            <appender-ref ref="console" />
+<!--            <appender-ref ref="console" />-->

Review Comment:
   It needs to be discussed in different situations because this configuration file will be used by both the IDE launch and script usage:
   
   - If started using a script, take pd as an example, the output of the command line will be redirected to hugegraph-pd-stdout.log, and the logs defined within the log4j2.xml range will be obtained in hugegraph-pd.log (there will be a delay). **In fact, the content of the hugegraph-pd.log log is basically the same as that in hugegraph-pd-stdout.log**.
   - If started using an IDE, still using pd as an example, the command line output (pd runtime log) will be displayed in the RUN panel, and you will still get the logs within the range defined in log4j2.xml in the hugegraph-pd.log (there will be a delay).
   
   The conclusion is that if the script is used to start, the console appender is unnecessary. If the IDE is used to start, the console appender is meaningful (for timely observation of logs). Considering the delay in the generation of hugegraph-pd.log logs, it is recommended to keep the console appender.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] fix(pd/store): log files do not scroll with the process [incubator-hugegraph]

Posted by "VGalaxies (via GitHub)" <gi...@apache.org>.
VGalaxies commented on PR #2589:
URL: https://github.com/apache/incubator-hugegraph/pull/2589#issuecomment-2248073115

   merge it after https://github.com/apache/incubator-hugegraph/pull/2599


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] fix(pd/store): log files do not scroll with the process [incubator-hugegraph]

Posted by "VGalaxies (via GitHub)" <gi...@apache.org>.
VGalaxies commented on code in PR #2589:
URL: https://github.com/apache/incubator-hugegraph/pull/2589#discussion_r1681070388


##########
hugegraph-pd/hg-pd-dist/src/assembly/static/conf/log4j2.xml:
##########
@@ -129,7 +129,7 @@
         <!-- Use mixed async way to output logs -->

Review Comment:
   The comments here are somewhat outdated. I found that AsyncLogger is still being used in hugegraph-pd/hg-pd-service/src/main/resources/log4j2.xml. Any context @imbajin?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] fix(pd/store): log files do not scroll with the process [incubator-hugegraph]

Posted by "haohao0103 (via GitHub)" <gi...@apache.org>.
haohao0103 commented on code in PR #2589:
URL: https://github.com/apache/incubator-hugegraph/pull/2589#discussion_r1682010725


##########
hugegraph-pd/hg-pd-dist/src/assembly/static/bin/start-hugegraph-pd.sh:
##########
@@ -159,8 +159,10 @@ if [ $(ps -ef|grep -v grep| grep java|grep -cE ${CONF}) -ne 0 ]; then
 fi
 echo "Starting HugeGraphPDServer..."
 
+JVM_OPTIONS="-Djava.util.logging.manager=org.apache.logging.log4j.jul.LogManager"

Review Comment:
   > I found that pd here did not correctly configure the log4j file path...
   
   Actually, configure the log4j file path is not displayed here. It is actually configured in application.xml
   logging:
   config: 'file:./conf/log4j2.xml',



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] fix(pd/store): log files do not scroll with the process [incubator-hugegraph]

Posted by "VGalaxies (via GitHub)" <gi...@apache.org>.
VGalaxies commented on code in PR #2589:
URL: https://github.com/apache/incubator-hugegraph/pull/2589#discussion_r1682074111


##########
hugegraph-pd/hg-pd-dist/src/assembly/static/bin/start-hugegraph-pd.sh:
##########
@@ -159,8 +159,10 @@ if [ $(ps -ef|grep -v grep| grep java|grep -cE ${CONF}) -ne 0 ]; then
 fi
 echo "Starting HugeGraphPDServer..."
 
+JVM_OPTIONS="-Djava.util.logging.manager=org.apache.logging.log4j.jul.LogManager"

Review Comment:
   Currently, for store, it is specified in both JVM_OPTIONS and application.xml, so it might be good to unify that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] fix(pd/store): log files do not scroll with the process [incubator-hugegraph]

Posted by "haohao0103 (via GitHub)" <gi...@apache.org>.
haohao0103 commented on code in PR #2589:
URL: https://github.com/apache/incubator-hugegraph/pull/2589#discussion_r1677511058


##########
hugegraph-pd/hg-pd-dist/src/assembly/static/conf/log4j2.xml:
##########
@@ -129,7 +129,7 @@
         <!-- Use mixed async way to output logs -->
         <logger name="org.apache.hugegraph" level="INFO" additivity="false">
             <appender-ref ref="file" />
-            <appender-ref ref="console" />
+<!--            <appender-ref ref="console" />-->

Review Comment:
   I'm just considering redundancy. My understanding is that only the console appender was used in the org.apache.huggegraph logger, and it was duplicated with the file appender, so only one was kept? So I kept the file appender



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] fix(pd/store): log files do not scroll with the process [incubator-hugegraph]

Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #2589:
URL: https://github.com/apache/incubator-hugegraph/pull/2589


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] fix(pd/store): log files do not scroll with the process [incubator-hugegraph]

Posted by "VGalaxies (via GitHub)" <gi...@apache.org>.
VGalaxies commented on code in PR #2589:
URL: https://github.com/apache/incubator-hugegraph/pull/2589#discussion_r1681062295


##########
hugegraph-pd/hg-pd-dist/src/assembly/static/conf/log4j2.xml:
##########
@@ -129,7 +129,7 @@
         <!-- Use mixed async way to output logs -->
         <logger name="org.apache.hugegraph" level="INFO" additivity="false">
             <appender-ref ref="file" />
-            <appender-ref ref="console" />
+<!--            <appender-ref ref="console" />-->

Review Comment:
   It needs to be discussed in different situations because this configuration file will be used by both the IDE launch and script usage:
   
   - If started using a script, take pd as an example, the output of the command line will be redirected to hugegraph-pd-stdout.log, and the logs defined within the log4j2.xml range will be obtained in hugegraph-pd.log (there will be a delay). In fact, the content of the hugegraph-pd.log log is basically the same as that in hugegraph-pd-stdout.log.
   - If started using an IDE, still using pd as an example, the command line output (pd runtime log) will be displayed in the RUN panel, and you will still get the logs within the range defined in log4j2.xml in the hugegraph-pd.log (there will be a delay).
   
   The conclusion is that if the script is used to start, the console appender is unnecessary. If the IDE is used to start, the console appender is meaningful (for timely observation of logs). Considering the delay in the generation of hugegraph-pd.log logs, it is recommended to keep the console appender.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] fix(pd/store): log files do not scroll with the process [incubator-hugegraph]

Posted by "VGalaxies (via GitHub)" <gi...@apache.org>.
VGalaxies commented on code in PR #2589:
URL: https://github.com/apache/incubator-hugegraph/pull/2589#discussion_r1681062295


##########
hugegraph-pd/hg-pd-dist/src/assembly/static/conf/log4j2.xml:
##########
@@ -129,7 +129,7 @@
         <!-- Use mixed async way to output logs -->
         <logger name="org.apache.hugegraph" level="INFO" additivity="false">
             <appender-ref ref="file" />
-            <appender-ref ref="console" />
+<!--            <appender-ref ref="console" />-->

Review Comment:
   It needs to be discussed in different situations because this configuration file will be used by both the IDE launch and script usage:
   
   - If started using a script, take pd as an example, the output of the command line will be redirected to hugegraph-pd-stdout.log, and the logs defined within the log4j2.xml range will be obtained in hugegraph-pd.log (there will be a delay). In fact, the content of the `hugegraph-pd.log` log is basically the same as that in `hugegraph-pd-stdout.log`.
   - If started using an IDE, still using pd as an example, the command line output (pd runtime log) will be displayed in the RUN panel, and you will still get the logs within the range defined in log4j2.xml in the hugegraph-pd.log (there will be a delay).
   
   The conclusion is that if the script is used to start, the console appender is unnecessary. If the IDE is used to start, the console appender is meaningful (for timely observation of logs). Considering the delay in the generation of hugegraph-pd.log logs, it is recommended to keep the console appender.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] fix(pd/store): log files do not scroll with the process [incubator-hugegraph]

Posted by "VGalaxies (via GitHub)" <gi...@apache.org>.
VGalaxies commented on code in PR #2589:
URL: https://github.com/apache/incubator-hugegraph/pull/2589#discussion_r1681064805


##########
hugegraph-pd/hg-pd-dist/src/assembly/static/bin/start-hugegraph-pd.sh:
##########
@@ -159,8 +159,10 @@ if [ $(ps -ef|grep -v grep| grep java|grep -cE ${CONF}) -ne 0 ]; then
 fi
 echo "Starting HugeGraphPDServer..."
 
+JVM_OPTIONS="-Djava.util.logging.manager=org.apache.logging.log4j.jul.LogManager"

Review Comment:
   ```suggestion
   JVM_OPTIONS="-Dlog4j.configurationFile=${CONF}/log4j2.xml -Djava.util.logging.manager=org.apache.logging.log4j.jul.LogManager"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org