You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/16 11:27:39 UTC
[GitHub] [hudi] cuibo01 opened a new pull request, #5889: [MINOR]bootstrap op add keyby
cuibo01 opened a new pull request, #5889:
URL: https://github.com/apache/hudi/pull/5889
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5889: [MINOR]bootstrap op add keyby
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5889:
URL: https://github.com/apache/hudi/pull/5889#issuecomment-1157577611
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2963a50b03b5d8b09bf6631c39a67807aa88169b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2963a50b03b5d8b09bf6631c39a67807aa88169b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2963a50b03b5d8b09bf6631c39a67807aa88169b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #5889: [MINOR]bootstrap op add keyby
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #5889:
URL: https://github.com/apache/hudi/pull/5889#discussion_r898998291
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/Pipelines.java:
##########
@@ -249,6 +249,7 @@ private static DataStream<HoodieRecord> streamBootstrap(
if (conf.getBoolean(FlinkOptions.INDEX_BOOTSTRAP_ENABLED) || bounded) {
dataStream1 = dataStream1
+ .keyBy(HoodieRecord::getRecordKey)
.transform(
Review Comment:
Why shuffle the input by primary keys here ? We already shuffle the output of bootstrap operators by primary keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 closed pull request #5889: [MINOR]bootstrap op add keyby
Posted by GitBox <gi...@apache.org>.
danny0405 closed pull request #5889: [MINOR]bootstrap op add keyby
URL: https://github.com/apache/hudi/pull/5889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] cuibo01 commented on pull request #5889: [MINOR]bootstrap op add keyby
Posted by GitBox <gi...@apache.org>.
cuibo01 commented on PR #5889:
URL: https://github.com/apache/hudi/pull/5889#issuecomment-1157555906
The parallelism of rowDataToHoodieRecord(Map) and bootstrap may be different. Therefore, rowDataToHoodieRecord sends data to bootstrap by rebalance. Rebalance may send the same key to different parallelism of bootstrap . As a result, data with the same key is out of order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5889: [MINOR]bootstrap op add keyby
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5889:
URL: https://github.com/apache/hudi/pull/5889#issuecomment-1157764470
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2963a50b03b5d8b09bf6631c39a67807aa88169b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9339",
"triggerID" : "2963a50b03b5d8b09bf6631c39a67807aa88169b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2963a50b03b5d8b09bf6631c39a67807aa88169b Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9339)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5889: [MINOR]bootstrap op add keyby
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5889:
URL: https://github.com/apache/hudi/pull/5889#issuecomment-1157581735
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2963a50b03b5d8b09bf6631c39a67807aa88169b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9339",
"triggerID" : "2963a50b03b5d8b09bf6631c39a67807aa88169b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2963a50b03b5d8b09bf6631c39a67807aa88169b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9339)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #5889: [MINOR]bootstrap op add keyby
Posted by GitBox <gi...@apache.org>.
danny0405 commented on PR #5889:
URL: https://github.com/apache/hudi/pull/5889#issuecomment-1165258136
Close because i think it is not necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] cuibo01 commented on a diff in pull request #5889: [MINOR]bootstrap op add keyby
Posted by GitBox <gi...@apache.org>.
cuibo01 commented on code in PR #5889:
URL: https://github.com/apache/hudi/pull/5889#discussion_r899012138
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/Pipelines.java:
##########
@@ -249,6 +249,7 @@ private static DataStream<HoodieRecord> streamBootstrap(
if (conf.getBoolean(FlinkOptions.INDEX_BOOTSTRAP_ENABLED) || bounded) {
dataStream1 = dataStream1
+ .keyBy(HoodieRecord::getRecordKey)
.transform(
Review Comment:
The sequence of data received by the bucketAssign may change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org