You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/10/24 14:20:00 UTC
[jira] [Commented] (NIFI-12191) Simplify Integraton Test & Docker Test action workflows - MacOS GitHub Runner does not correctly run Docker (Colima)
[ https://issues.apache.org/jira/browse/NIFI-12191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779118#comment-17779118 ]
ASF subversion and git services commented on NIFI-12191:
--------------------------------------------------------
Commit 4ff4f77dd88af80254f4821fbe1396822f705b8e in nifi's branch refs/heads/main from Chris Sampson
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4ff4f77dd8 ]
NIFI-12191 Simplified integration-tests and docker-tests Workflows
This closes #7920
Signed-off-by: David Handermann <ex...@apache.org>
> Simplify Integraton Test & Docker Test action workflows - MacOS GitHub Runner does not correctly run Docker (Colima)
> --------------------------------------------------------------------------------------------------------------------
>
> Key: NIFI-12191
> URL: https://issues.apache.org/jira/browse/NIFI-12191
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Chris Sampson
> Assignee: Chris Sampson
> Priority: Major
> Fix For: 2.latest
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> NIFI-12177 introduced the {{integration-tests}} and {{docker-tests}} GitHub Action Workflows, which runs fine on {{Ubuntu}}, but cannot run as successfully on {{MacOS}}.
> This is because the MacOS runner **does not** contain Docker by default, and installing it via {{brew install docker}} actually installs [Colima|https://github.com/abiosoft/colima]. While this allows Docker Images to be built and (to a degree) run as Containers, it has been noted that Testcontainers **do not** work correctly with such a setup, and some of the Docker Image Tests (e.g. for NiFi - see NIFI-12177) fail because containers don't run in a consistent manner compared to Ubuntu with `docker` installed.
> -This ticket is to investigate and fix the use of Docker within the MacOS based GitHub runner for these workflows.- After some investigation and [discussion|https://github.com/apache/nifi/pull/7920], it has been decided that the potential benefits of running the tests on MacOS as well as Ubuntu are not sufficient to justify the extra resource cost of the GitHub Runners. Instead, it has been decided to simplify the Workflows added in NIFI-12177 to only run {{integration-tests}} and {{docker-tests}} on Ubuntu-based GitHub Action Runners.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)