You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "adriangb (via GitHub)" <gi...@apache.org> on 2025/09/23 01:02:20 UTC
[PR] add column descriptions to info schemas [datafusion]
adriangb opened a new pull request, #17734:
URL: https://github.com/apache/datafusion/pull/17734
postgres supports column descriptions, but accessing them is quite convoluted (https://stackoverflow.com/questions/343138/retrieving-comments-from-a-postgresql-db). I think we can do better, this is the best I came up with. I'm somewhat arbitrarily choosing the metadataa field 'description' to hold this information, but I don't see a better way to do it and it seems unlikely things will break even if someone is using that for something else
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] add column descriptions to info schemas [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb closed pull request #17734: add column descriptions to info schemas
URL: https://github.com/apache/datafusion/pull/17734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] add column descriptions to info schemas [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #17734:
URL: https://github.com/apache/datafusion/pull/17734#discussion_r2373051430
##########
datafusion/catalog/src/information_schema.rs:
##########
@@ -891,6 +894,10 @@ impl InformationSchemaColumnsBuilder {
self.datetime_precisions.append_option(None);
self.interval_types.append_null();
+
+ // Extract description from field metadata
+ let description = field.metadata().get("description");
Review Comment:
if we are going to do this, I think we should document the behavior somewhere (in doc comments of InformationSchemaColumnsBuilder at least)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] add column descriptions to info schemas [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on PR #17734:
URL: https://github.com/apache/datafusion/pull/17734#issuecomment-3325031934
I think we're going to go in another direction: we'll add an internal endpoint to do pretty much the same thing. I think this change makes sense and is a nice addition but I would like another user that is not me to request it, otherwise I feel like I'm pushing through complexity for a feature that only we may end up using. Thanks for taking a look Andrew.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org