You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/17 07:45:06 UTC

[GitHub] [spark] MaxGekk commented on pull request #31858: [SPARK-34768][SQL] Respect the default input buffer size in Univocity

MaxGekk commented on pull request #31858:
URL: https://github.com/apache/spark/pull/31858#issuecomment-800870879


   >  I believe it's better to use default buffer size for stability,
   
   I agree.
   
   > potentially better performance, etc. in any event.
   
   It would be nice to re-run CSV benchmarks. Though we can do that separately from this PR.
   
   > It will also fix uniVocity/univocity-parsers#449
   
   Could you update PR's description as it doesn't fix the issue.
   
   > ^ is a regression compared to Spark 2.4
   
   Are you sure about this. The related code in uniVocity is old. I guess 2.4 might have the same problem.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org