You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/03/16 13:47:55 UTC

[GitHub] [trafficcontrol] bakerolls opened a new pull request #3411: CIAB: Export UDP ports for the DNS

bakerolls opened a new pull request #3411: CIAB: Export UDP ports for the DNS
URL: https://github.com/apache/trafficcontrol/pull/3411
 
 
   ## Which issue is fixed by this PR? If not related to an existing issue, what does this PR do?
   
   By default, [Docker only exposes TCP](https://docs.docker.com/compose/reference/port/) but most DNS servers use UDP. The protocol can be specified by [appending `/protocol` to the exposed port](https://docs.docker.com/compose/compose-file/compose-file-v2/#ports). In case TCs DNS switches to TCP in the future, both protocols are specified.
   
   Since this is a very small change that does not modify any code or functionality, I hope it can be reviewed without being discussed on the mailing list.
   
   ## Which TC components are affected by this PR?
   
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Analytics
   - [ ] Traffic Monitor
   - [ ] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [x] CDN in a Box
   
   ## What is the best way to verify this PR? Please include manual steps or automated tests.
   ### (If no tests are part of this PR, please provide explanation as to why no tests are included.)
   
   Start CIAB as described in its readme, then use dig to test the DNS:
   
   ```
   $ docker-compose -f docker-compose.yml -f docker-compose.expose-ports.yml up -d
   $ dig @127.0.0.1 -p 3053 video.demo1.mycdn.ciab.test
   ```
   
   
   ## Check all that apply
   
   - [ ] This PR includes tests
   - [ ] This PR includes documentation updates
   - [ ] This PR includes an update to CHANGELOG.md
   - [ ] This PR includes all required license headers
   - [ ] This PR includes a database migration (ensure that migration sequence is correct)
   - [ ] This PR fixes a serious security flaw. Read more: [www.apache.org/security](http://www.apache.org/security/)
   
   <!--
       Licensed to the Apache Software Foundation (ASF) under one
       or more contributor license agreements.  See the NOTICE file
       distributed with this work for additional information
       regarding copyright ownership.  The ASF licenses this file
       to you under the Apache License, Version 2.0 (the
       "License"); you may not use this file except in compliance
       with the License.  You may obtain a copy of the License at
   
         http://www.apache.org/licenses/LICENSE-2.0
   
       Unless required by applicable law or agreed to in writing,
       software distributed under the License is distributed on an
       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
       KIND, either express or implied.  See the License for the
       specific language governing permissions and limitations
       under the License.
   -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services