You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "linghengqian (via GitHub)" <gi...@apache.org> on 2025/12/22 15:17:11 UTC
[PR] Bump Netty to 4.2.9 [shardingsphere]
linghengqian opened a new pull request, #37460:
URL: https://github.com/apache/shardingsphere/pull/37460
For https://github.com/apache/shardingsphere/issues/35052#issuecomment-3681366044 .
Changes proposed in this pull request:
- Bump Netty to 4.2.9 . This was actually cut from https://github.com/apache/shardingsphere/pull/37357, which is tested for Windows 11. This is because https://github.com/netty/netty/pull/15877 is only available on Netty `4.2.3+`. The underlying reason is that JDK 25's Arena has issues with GraalVM Native Images, and Netty uses Arena as a backup solution in JDK 25, see https://netty.io/wiki/java-24-and-sun.misc.unsafe.html and https://www.graalvm.org/jdk25/reference-manual/native-image/native-code-interoperability/ffm-api/ .
- `netty-codec-protobuf` now requires manual dependency declaration; it is no longer implicitly depended on by other Netty modules. However, places like `org.apache.shardingsphere.proxy.frontend.netty.CDCServerHandlerInitializer` still use `io.netty.handler.codec.protobuf.**`.
- Update the Docker image used by Doris' nativeTest. This is primarily to apply the changes in https://github.com/dyrnq/docker-doris/issues/38 .
- Update the nativeTest of SQL Server 2025 to obtain GraalVM Reachability Metadata related to the `DROP TABLE` syntax. However, the Shardingsphere master branch still does not support the `DROP TABLE IF` syntax on SQL Server 2025. See https://learn.microsoft.com/zh-cn/sql/t-sql/statements/drop-table-transact-sql?view=sql-server-ver17#if-exists .
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [x] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump Netty to 4.2.9 [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #37460:
URL: https://github.com/apache/shardingsphere/pull/37460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org