You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/07 17:58:15 UTC
[GitHub] [spark] allisonwang-db opened a new pull request, #38968: [SPARK-41441][SQL] Support Generate with no required child output to host outer references
allisonwang-db opened a new pull request, #38968:
URL: https://github.com/apache/spark/pull/38968
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
This PR supports `Generate` with no required child output to host outer references. It updates DecorrelateInnerQuery to handle Generate and adds a new optimization for Generate and OneRowRelation in rule OptimizeOneRowRelationSubquery.
### Why are the changes needed?
Currently, CheckAnalysis allows `Generate` with no required child output to host outer references. However, DecorrelateInnerQuery does not handle this case correctly. For example
```
select * from t, lateral (select explode(array(c1, c2)))
```
This will throw an internal error:
```
AssertionError: assertion failed: Correlated column is not allowed in Generate
```
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Unit tests and SQL query tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on pull request #38968: [SPARK-41441][SQL] Support Generate with no required child output to host outer references
Posted by GitBox <gi...@apache.org>.
allisonwang-db commented on PR #38968:
URL: https://github.com/apache/spark/pull/38968#issuecomment-1343342635
cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38968: [SPARK-41441][SQL] Support Generate with no required child output to host outer references
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38968:
URL: https://github.com/apache/spark/pull/38968#discussion_r1046690391
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala:
##########
@@ -774,15 +775,28 @@ object OptimizeOneRowRelationSubquery extends Rule[LogicalPlan] {
*/
private def rewrite(plan: LogicalPlan): LogicalPlan = plan.transformUpWithSubqueries {
case LateralJoin(
- left, right @ LateralSubquery(OneRowSubquery(projectList), _, _, _, _), _, None)
+ left, right @ LateralSubquery(OneRowSubquery(plan), _, _, _, _), _, None)
if !hasCorrelatedSubquery(right.plan) && right.joinCond.isEmpty =>
- Project(left.output ++ projectList, left)
+ plan match {
+ case Project(projectList, _: OneRowRelation) =>
+ val newPList = stripOuterReferences(projectList)
+ Project(left.output ++ newPList, left)
+
+ case g @ Generate(generator, _, _, _, _, _: OneRowRelation) =>
+ val newGenerator = stripOuterReference(generator)
+ g.copy(generator = newGenerator, child = left)
+
+ case o =>
+ throw new IllegalStateException(
Review Comment:
we should use `SparkThrowable.internalError`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #38968: [SPARK-41441][SQL] Support Generate with no required child output to host outer references
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #38968:
URL: https://github.com/apache/spark/pull/38968#issuecomment-1357560347
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #38968: [SPARK-41441][SQL] Support Generate with no required child output to host outer references
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #38968: [SPARK-41441][SQL] Support Generate with no required child output to host outer references
URL: https://github.com/apache/spark/pull/38968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38968: [SPARK-41441][SQL] Support Generate with no required child output to host outer references
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38968:
URL: https://github.com/apache/spark/pull/38968#discussion_r1046688763
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/DecorrelateInnerQuery.scala:
##########
@@ -667,6 +667,18 @@ object DecorrelateInnerQuery extends PredicateHelper {
val newJoin = j.copy(left = newLeft, right = newRight, condition = newCondition)
(newJoin, newJoinCond, newOuterReferenceMap)
+ case g: Generate if g.requiredChildOutput.isEmpty =>
+ // Generate with non-empty required child output cannot host
+ // outer reference. It is blocked by CheckAnalysis.
+ val outerReferences = collectOuterReferences(g.expressions)
Review Comment:
is this always `Nil`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org