[GitHub] [maven-compiler-plugin] loizbak commented on issue #27: MCOMPILER-372 - fix test compile issue: added dependency test path for modules

[GitBox <gi...@apache.org>]

loizbak commented on issue #27: MCOMPILER-372 - fix test compile issue: added dependency test path for modules
URL: https://github.com/apache/maven-compiler-plugin/pull/27#issuecomment-571291973
 
 
   OK, on going.
   
   Le ven. 3 janv. 2020 à 21:13, Robert Scholte <no...@github.com> a
   écrit :
   
   > *@rfscholte* commented on this pull request.
   > ------------------------------
   >
   > In src/main/java/org/apache/maven/plugin/compiler/TestCompilerMojo.java
   > <https://github.com/apache/maven-compiler-plugin/pull/27#discussion_r362945805>
   > :
   >
   > >              }
   >          }
   >      }
   >
   > +    /**
   > +     * Get module test path element from module path element
   > +     * @param modulePathElt
   > +     * @return
   > +     */
   > +    private File getModuleTestPathElt( File modulePathElt )
   >
   > This methods feels a bit like best guessing. It is better to loop over all
   > the reactorProjects to find the Paths that belong to the same Maven Project
   > (and because of that to the same module)
   >
   > —
   > You are receiving this because you modified the open/close state.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/maven-compiler-plugin/pull/27?email_source=notifications&email_token=AEKICU6WINGDTYY24MQIFSTQ36L7LA5CNFSM4J33NR7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQUVZPQ#pullrequestreview-338255038>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AEKICU7SGD5HUI6VWYOCDADQ36L7LANCNFSM4J33NR7A>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services