[GitHub] [arrow] rok commented on pull request #11026: ARROW-13561: [C++] Implement week kernel that accepts DayOfWeekOptions

[GitBox <gi...@apache.org>]

rok commented on pull request #11026:
URL: https://github.com/apache/arrow/pull/11026#issuecomment-910413676


   @ianmcook This now covers MySQL WEEK modes 1, 3, 4 and 6 (week 1 is the first week with 4 or more days this year).
   If we want to cover modes 0, 2,  5, and 7 (week 1 is the first week with a Monday/Sunday in this year) we could to add another parameter e.g.: `DayOfWeekOptions.week_start_in_year`. Do you think we should?
   
   Another thing to note here is that `DayOfWeekOptions.one_based_numbering` doesn't exactly mean we count from 0 or 1 but rather that a date from week 52 of previous year that is in this year will be counted as 0 instead of 52. It's a MySQL convention.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org