You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Alejandro Abdelnur (JIRA)" <ji...@apache.org> on 2012/12/18 18:00:16 UTC

[jira] [Commented] (OOZIE-1035) Improve forkjoin validation to allow same errorTo transitions

    [ https://issues.apache.org/jira/browse/OOZIE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13535046#comment-13535046 ] 

Alejandro Abdelnur commented on OOZIE-1035:
-------------------------------------------

It seems the validate logic has a flaw as it is implemented because it is working depth first.

The following WF (from a testcase) should be a failure because 3 may end up be executing twice, once from the fork and once from the decision.

{code}
     *f->(2,3)
     *2->decision node->{3,4}
     *3->ok->j
     *3->fail->k
     *4->ok->j
     *4->fail->k
     *j->end
{code}

The test is assuming this WF is correct and because of that is passing.

Also, in the *validateForkJoin()* method, START and JOIN nodes have always a single transition, thus no need to do an iterator.



                
> Improve forkjoin validation to allow same errorTo transitions
> -------------------------------------------------------------
>
>                 Key: OOZIE-1035
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1035
>             Project: Oozie
>          Issue Type: Improvement
>          Components: workflow
>    Affects Versions: trunk
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>            Priority: Minor
>             Fix For: trunk
>
>         Attachments: OOZIE-1035.patch
>
>
> It seems common that users will have the "error to" transition from every action go to the same action node (e.g. email action), which then goes to the kill node instead of just going to the kill node directly.  When this is done in action nodes within a forkjoin path, the forkjoin validation doesn't allow it.  We should improve the forkjoin validation code to allow the same "error to" transition, as long as it eventually leads to a kill or end node.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira