You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by gdfm <gi...@git.apache.org> on 2015/01/23 15:44:23 UTC
[GitHub] storm pull request: STORM-632: New grouping for better load balanc...
GitHub user gdfm opened a pull request:
https://github.com/apache/storm/pull/395
STORM-632: New grouping for better load balancing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gdfm/storm STORM-632
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/395.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #395
----
commit 2c181e9b57ad4f56f8ccca79ca2ceac574492bc1
Author: Gianmarco De Francisci Morales <gd...@gdfm.me>
Date: 2013-12-12T11:35:47Z
Update README.markdown
commit ab8a77614f26737427f2f8c69bf1e74e169c78a6
Author: Gianmarco De Francisci Morales <gd...@gdfm.me>
Date: 2013-12-12T12:03:40Z
add eclipse files to .gitingore
commit 1d9bfb38f9f49672df05657bd65935fbb346b588
Author: Gianmarco De Francisci Morales <gd...@gdfm.me>
Date: 2014-12-08T15:15:52Z
Merge branch 'master' of github.com:apache/incubator-storm
Conflicts:
.gitignore
README.markdown
commit 42398f6ffb7d4b0df14a127e1111db54cde62a81
Author: Gianmarco De Francisci Morales <gd...@apache.org>
Date: 2015-01-23T11:48:46Z
Merge branch 'master' of github.com:apache/incubator-storm
commit 259c8c25ae7187b3a5fc735a111d14b77d6233c0
Author: Gianmarco De Francisci Morales <gd...@apache.org>
Date: 2015-01-23T14:36:08Z
Java implementation of partial key grouping + test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-632: New grouping for better load balanc...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/395#issuecomment-71210952
+1 I also filed STORM-637 as a follow on JIRA to finish the integration.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-632: New grouping for better load balanc...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/395#issuecomment-71312933
Great research, +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-632: New grouping for better load balanc...
Posted by gdfm <gi...@git.apache.org>.
Github user gdfm commented on the pull request:
https://github.com/apache/storm/pull/395#issuecomment-71212234
I always forget them :)
Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-632: New grouping for better load balanc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/395
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-632: New grouping for better load balanc...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/395#issuecomment-71211116
Oops I missed one thing. None of the new files have the Apache header in them. I am +1 once the header in all of the other java files is also in these.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-632: New grouping for better load balanc...
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/395#issuecomment-71250215
LGTM. +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---