[GitHub] [cloudstack] weizhouapache commented on pull request #7067: UI: Enable shared network with scope option in advanced zone with SG

[GitBox <gi...@apache.org>]

weizhouapache commented on PR #7067:
URL: https://github.com/apache/cloudstack/pull/7067#issuecomment-1383937109

   > @weizhouapache have you checked against old/legacy UI and also:
   > 
   > * What if the env has several zones (both SG enabled and not)
   > * On the other hand, to show/hide security groups (tab or the create button) when any of the zones don't have SG enable?
   > 
   > Otherwise LGTM.
   
   @rohityadavcloud 
   I have not tested with multiple zones.  zone with advanced and zone with advanced SG work well in my testing.
   
   If there are multiple zone , for example 1 advanced zone and 1 advanced zone with SG, it is possible that domain admin and regular user can open the dialog, but cannot create shared networks in the advanced zone with SG.
   
   I will test it. @DaanHoogland do not merge now.
   
   (security groups tab is displayed only if there are zones with SG enabled, it works since primate UI was introduced in 4.15.0)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org