You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "pandaapo (via GitHub)" <gi...@apache.org> on 2023/04/21 14:57:15 UTC
[GitHub] [eventmesh] pandaapo opened a new pull request, #3792: [ISSUE #3473]The code processing logic is the same in both places.
pandaapo opened a new pull request, #3792:
URL: https://github.com/apache/eventmesh/pull/3792
Fixes #3473.
### Motivation
### Modifications
Reuse code logic and use some api provided officially.
### Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on pull request #3792: [ISSUE #3473]The code processing logic is the same in both places.
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on PR #3792:
URL: https://github.com/apache/eventmesh/pull/3792#issuecomment-1527060592
It's okay, we can just merge you this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] pandaapo commented on pull request #3792: [ISSUE #3473]The code processing logic is the same in both places.
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #3792:
URL: https://github.com/apache/eventmesh/pull/3792#issuecomment-1524578505
> The `SendMessageRequestProtocolResolver` class modification has been proposed, I think your modification is better, and someone mentioned pr. try to correspond to a pr for an issue. review the time convenient. issue ##3653 pr #3709
Sorry. Sometimes I make more modifications by the way when I find more things during fixing an issue.
Do you want me to rollback modifications related to issue #3653 and review its pr? Or want me to rollback and post a new pr to issue #3653?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on pull request #3792: [ISSUE #3473]The code processing logic is the same in both places.
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on PR #3792:
URL: https://github.com/apache/eventmesh/pull/3792#issuecomment-1524474856
The `SendMessageRequestProtocolResolver` class modification has been proposed, I think your modification is better, and someone mentioned pr. try to correspond to a pr for an issue. review the time convenient.
issue ##3653
pr #3709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3792: [ISSUE #3473]The code processing logic is the same in both places.
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3792:
URL: https://github.com/apache/eventmesh/pull/3792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3792: [ISSUE #3473]The code processing logic is the same in both places.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3792:
URL: https://github.com/apache/eventmesh/pull/3792#issuecomment-1521099182
## [Codecov](https://codecov.io/gh/apache/eventmesh/pull/3792?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3792](https://codecov.io/gh/apache/eventmesh/pull/3792?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (55daf08) into [master](https://codecov.io/gh/apache/eventmesh/commit/7d3bbde05289982d19ab39ff1a8f1c55a382e5d5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d3bbde) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 55daf08 differs from pull request most recent head 575e09c. Consider uploading reports for the commit 575e09c to get more accurate results
```diff
@@ Coverage Diff @@
## master #3792 +/- ##
============================================
- Coverage 13.80% 13.79% -0.01%
Complexity 1291 1291
============================================
Files 571 571
Lines 29154 29116 -38
Branches 2856 2850 -6
============================================
- Hits 4024 4018 -6
+ Misses 24756 24722 -34
- Partials 374 376 +2
```
| [Impacted Files](https://codecov.io/gh/apache/eventmesh/pull/3792?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...olver/http/SendMessageBatchV2ProtocolResolver.java](https://codecov.io/gh/apache/eventmesh/pull/3792?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXByb3RvY29sLXBsdWdpbi9ldmVudG1lc2gtcHJvdG9jb2wtbWVzaG1lc3NhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9wcm90b2NvbC9tZXNobWVzc2FnZS9yZXNvbHZlci9odHRwL1NlbmRNZXNzYWdlQmF0Y2hWMlByb3RvY29sUmVzb2x2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...olver/http/SendMessageRequestProtocolResolver.java](https://codecov.io/gh/apache/eventmesh/pull/3792?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXByb3RvY29sLXBsdWdpbi9ldmVudG1lc2gtcHJvdG9jb2wtbWVzaG1lc3NhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9wcm90b2NvbC9tZXNobWVzc2FnZS9yZXNvbHZlci9odHRwL1NlbmRNZXNzYWdlUmVxdWVzdFByb3RvY29sUmVzb2x2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...rg/apache/eventmesh/runtime/registry/Registry.java](https://codecov.io/gh/apache/eventmesh/pull/3792?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3JlZ2lzdHJ5L1JlZ2lzdHJ5LmphdmE=) | `4.87% <0.00%> (-0.26%)` | :arrow_down: |
... and [8 files with indirect coverage changes](https://codecov.io/gh/apache/eventmesh/pull/3792/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org