You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by st...@apache.org on 2022/09/27 13:26:59 UTC

[impala] branch master updated: IMPALA-11611: Replace THRIFT_HOME with THIFT_JAVA_HOME in fe/pom.xml

This is an automated email from the ASF dual-hosted git repository.

stigahuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git


The following commit(s) were added to refs/heads/master by this push:
     new 845d468ce IMPALA-11611: Replace THRIFT_HOME with THIFT_JAVA_HOME in fe/pom.xml
845d468ce is described below

commit 845d468ce8add3269a4dd47d46d28266eb452b09
Author: Riza Suminto <ri...@cloudera.com>
AuthorDate: Sat Sep 24 05:41:15 2022 -0700

    IMPALA-11611: Replace THRIFT_HOME with THIFT_JAVA_HOME in fe/pom.xml
    
    IMPALA-11369 should replace all occurrences of THRIFT_HOME with either
    of THRIFT_CPP_HOME, THRIFT_JAVA_HOME, or THRIFT_PY_HOME. However, it
    miss replacing THRIFT_HOME to THRIFT_JAVA_HOME in fe/pom.xml.
    
    This reference has not cause an issue in compilation so far, but it
    should be replaced with the right one. This patch does that replacement.
    
    Testing:
    - Run and pass ./buildall.sh -skiptests -notests
    
    Change-Id: Ic39d47375353bb4d98399b5ff765d63aa331f63d
    Reviewed-on: http://gerrit.cloudera.org:8080/19040
    Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 fe/pom.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fe/pom.xml b/fe/pom.xml
index ba69bd5d0..f0dc1c603 100644
--- a/fe/pom.xml
+++ b/fe/pom.xml
@@ -1007,11 +1007,11 @@ under the License.
       <id>thrift-home-defined</id>
       <activation>
         <file>
-          <exists>${env.THRIFT_HOME}/bin/thrift</exists>
+          <exists>${env.THRIFT_JAVA_HOME}/bin/thrift</exists>
           </file>
       </activation>
       <properties>
-        <thrift.executable>${env.THRIFT_HOME}/bin/thrift</thrift.executable>
+        <thrift.executable>${env.THRIFT_JAVA_HOME}/bin/thrift</thrift.executable>
       </properties>
     </profile>
     <profile>