You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "bartosz25 (via GitHub)" <gi...@apache.org> on 2023/07/13 12:48:59 UTC
[GitHub] [spark] bartosz25 opened a new pull request, #41988: [MINOR][SS][DOCS] Fix typos in the Scaladoc and make the semantic of getCurrentWatermarkMs explicit
bartosz25 opened a new pull request, #41988:
URL: https://github.com/apache/spark/pull/41988
### What changes were proposed in this pull request?
Improve the code comments:
1. Rate micro-batch data source Scaladoc parameters aren't consistent with the options really supported by this data source.
2. The `getCurrentWatermarkMs` has a special semantic for the 1st micro-batch when the watermark is not set yet. IMO, it should return `Option[Long]`, hence `None` instead of `0` for the first micro-batch, but since it's a breaking change, I preferred to add a note on that instead.
### Why are the changes needed?
1. Avoid confusion while using the classes and methods.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
The tests weren't added because the change is only at the Scaladoc level. I affirm that the contribution is my original work and that I license the work to the project under the project's open source license.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #41988: [MINOR][SS][DOCS] Fix typos in the Scaladoc and make the semantic of getCurrentWatermarkMs explicit
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #41988:
URL: https://github.com/apache/spark/pull/41988#issuecomment-1636770712
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #41988: [MINOR][SS][DOCS] Fix typos in the Scaladoc and make the semantic of getCurrentWatermarkMs explicit
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #41988: [MINOR][SS][DOCS] Fix typos in the Scaladoc and make the semantic of getCurrentWatermarkMs explicit
URL: https://github.com/apache/spark/pull/41988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org