[jira] [Work logged] (HADOOP-17461) Add thread-level IOStatistics Context

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-17461?focusedWorklogId=774010&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-774010 ]

ASF GitHub Bot logged work on HADOOP-17461:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/May/22 13:39
            Start Date: 24/May/22 13:39
    Worklog Time Spent: 10m 
      Work Description: mehakmeet opened a new pull request, #4352:
URL: https://github.com/apache/hadoop/pull/4352

   ### Description of PR
   Adding Thread-level IOStatsitics in hadoop-common and implementing it in S3A Streams.
   
   ### How was this patch tested?
   Region: ap-south-1
   `mvn clean verify -Dparallel-tests -DtestsThreadCount=4 -Dscale`
   
   All tests ran fine.
   ### For code changes:
   
   - [X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
   - [X] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
   - [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [X] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 774010)
    Remaining Estimate: 0h
            Time Spent: 10m

> Add thread-level IOStatistics Context
> -------------------------------------
>
>                 Key: HADOOP-17461
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17461
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs, fs/azure, fs/s3
>    Affects Versions: 3.3.1
>            Reporter: Steve Loughran
>            Assignee: Mehakmeet Singh
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> For effective reporting of the iostatistics of individual worker threads, we need a thread-level context which IO components update.
> * this contact needs to be passed in two background thread forming work on behalf of a task.
> * IO Components (streams, iterators, filesystems) need to update this context statistics as they perform work
> * Without double counting anything.
> I imagine a ThreadLocal IOStatisticContext which will be updated in the FileSystem API Calls. This context MUST be passed into the background threads used by a task, so that IO is correctly aggregated.
> I don't want streams, listIterators &c to do the updating as there is more risk of double counting. However, we need to see their statistics if we want to know things like "bytes discarded in backwards seeks". And I don't want to be updating a shared context object on every read() call.
> If all we want is store IO (HEAD, GET, DELETE, list performance etc) then the FS is sufficient. 
> If we do want the stream-specific detail, then I propose
> * caching the context in the constructor
> * updating it only in close() or unbuffer() (as we do from S3AInputStream to S3AInstrumenation)
> * excluding those we know the FS already collects.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org