You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2015/03/27 14:10:29 UTC
Review Request 32571: Draw Number widget from the relevant retrieved
widget data from the API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32571/
-----------------------------------------------------------
Review request for Ambari and Andriy Babiichuk.
Bugs: AMBARI-10223
https://issues.apache.org/jira/browse/AMBARI-10223
Repository: ambari
Description
-------
A Number widget will be an implementation of Template widget_type.
A Number widget is a template widget_type with value having exactly one expression
Diffs
-----
ambari-web/app/assets/data/metrics/HBASE/Append_num_ops_&_Delete_num_ops.json 97d1bee
ambari-web/app/assets/data/widget_layouts/HBASE/stack_layout.json f921ad7
ambari-web/app/assets/test/tests.js de14b7c
ambari-web/app/mixins.js 7517c0d
ambari-web/app/mixins/common/widget_mixin.js PRE-CREATION
ambari-web/app/models/widget.js 3d0ddc7
ambari-web/app/styles/widget_layout.less PRE-CREATION
ambari-web/app/templates/common/widget/template_widget.hbs PRE-CREATION
ambari-web/app/templates/main/service/info/summary.hbs b6a5e1d
ambari-web/app/views.js f450182
ambari-web/app/views/common/widget/template_widget_view.js PRE-CREATION
ambari-web/test/mixins/common/widget_mixin_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/32571/diff/
Testing
-------
5704 tests complete (12 seconds)
68 tests pending
Thanks,
Andrii Tkach
Re: Review Request 32571: Draw Number widget from the relevant
retrieved widget data from the API
Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32571/#review78039
-----------------------------------------------------------
Ship it!
Ship It!
- Andriy Babiichuk
On Март 27, 2015, 1:18 п.п., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32571/
> -----------------------------------------------------------
>
> (Updated Март 27, 2015, 1:18 п.п.)
>
>
> Review request for Ambari and Andriy Babiichuk.
>
>
> Bugs: AMBARI-10223
> https://issues.apache.org/jira/browse/AMBARI-10223
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A Number widget will be an implementation of Template widget_type.
> A Number widget is a template widget_type with value having exactly one expression
>
>
> Diffs
> -----
>
> ambari-web/app/assets/data/metrics/HBASE/Append_num_ops_&_Delete_num_ops.json 97d1bee
> ambari-web/app/assets/data/widget_layouts/HBASE/stack_layout.json f921ad7
> ambari-web/app/assets/test/tests.js de14b7c
> ambari-web/app/mixins.js 7517c0d
> ambari-web/app/mixins/common/widget_mixin.js PRE-CREATION
> ambari-web/app/models/widget.js 3d0ddc7
> ambari-web/app/styles/widget_layout.less PRE-CREATION
> ambari-web/app/templates/common/widget/template_widget.hbs PRE-CREATION
> ambari-web/app/templates/main/service/info/summary.hbs b6a5e1d
> ambari-web/app/views.js f450182
> ambari-web/app/views/common/widget/graph_widget_view.js a6cd420
> ambari-web/app/views/common/widget/template_widget_view.js PRE-CREATION
> ambari-web/test/mixins/common/widget_mixin_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32571/diff/
>
>
> Testing
> -------
>
> 5704 tests complete (12 seconds)
> 68 tests pending
>
>
> Thanks,
>
> Andrii Tkach
>
>
Re: Review Request 32571: Draw Number widget from the relevant
retrieved widget data from the API
Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32571/
-----------------------------------------------------------
(Updated Март 27, 2015, 1:18 п.п.)
Review request for Ambari and Andriy Babiichuk.
Bugs: AMBARI-10223
https://issues.apache.org/jira/browse/AMBARI-10223
Repository: ambari
Description
-------
A Number widget will be an implementation of Template widget_type.
A Number widget is a template widget_type with value having exactly one expression
Diffs (updated)
-----
ambari-web/app/assets/data/metrics/HBASE/Append_num_ops_&_Delete_num_ops.json 97d1bee
ambari-web/app/assets/data/widget_layouts/HBASE/stack_layout.json f921ad7
ambari-web/app/assets/test/tests.js de14b7c
ambari-web/app/mixins.js 7517c0d
ambari-web/app/mixins/common/widget_mixin.js PRE-CREATION
ambari-web/app/models/widget.js 3d0ddc7
ambari-web/app/styles/widget_layout.less PRE-CREATION
ambari-web/app/templates/common/widget/template_widget.hbs PRE-CREATION
ambari-web/app/templates/main/service/info/summary.hbs b6a5e1d
ambari-web/app/views.js f450182
ambari-web/app/views/common/widget/graph_widget_view.js a6cd420
ambari-web/app/views/common/widget/template_widget_view.js PRE-CREATION
ambari-web/test/mixins/common/widget_mixin_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/32571/diff/
Testing
-------
5704 tests complete (12 seconds)
68 tests pending
Thanks,
Andrii Tkach
Re: Review Request 32571: Draw Number widget from the relevant
retrieved widget data from the API
Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32571/
-----------------------------------------------------------
(Updated Март 27, 2015, 1:15 п.п.)
Review request for Ambari and Andriy Babiichuk.
Bugs: AMBARI-10223
https://issues.apache.org/jira/browse/AMBARI-10223
Repository: ambari
Description
-------
A Number widget will be an implementation of Template widget_type.
A Number widget is a template widget_type with value having exactly one expression
Diffs (updated)
-----
ambari-web/app/assets/data/metrics/HBASE/Append_num_ops_&_Delete_num_ops.json 97d1bee
ambari-web/app/assets/data/widget_layouts/HBASE/stack_layout.json f921ad7
ambari-web/app/assets/test/tests.js de14b7c
ambari-web/app/mixins.js 7517c0d
ambari-web/app/mixins/common/widget_mixin.js PRE-CREATION
ambari-web/app/models/widget.js 3d0ddc7
ambari-web/app/styles/widget_layout.less PRE-CREATION
ambari-web/app/templates/common/widget/template_widget.hbs PRE-CREATION
ambari-web/app/templates/main/service/info/summary.hbs b6a5e1d
ambari-web/app/views.js f450182
ambari-web/app/views/common/widget/template_widget_view.js PRE-CREATION
ambari-web/test/mixins/common/widget_mixin_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/32571/diff/
Testing
-------
5704 tests complete (12 seconds)
68 tests pending
Thanks,
Andrii Tkach