You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "liferoad (via GitHub)" <gi...@apache.org> on 2023/08/15 19:57:59 UTC
[GitHub] [beam] liferoad opened a new pull request, #28013: use google form for feedback
liferoad opened a new pull request, #28013:
URL: https://github.com/apache/beam/pull/28013
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28013: use google form for feedback
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28013:
URL: https://github.com/apache/beam/pull/28013#issuecomment-1689854010
Reminder, please take a look at this pr: @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] liferoad commented on pull request #28013: use google form for feedback
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #28013:
URL: https://github.com/apache/beam/pull/28013#issuecomment-1679519867
Tested the button using https://htmlpreview.github.io/?https://github.com/apache/beam/blob/f6f27018f1b637f8d2d2d8d43dde93fa1580499e/website/www/site/layouts/partials/feedback.html. It is working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay merged pull request #28013: use google form for feedback
Posted by "aaltay (via GitHub)" <gi...@apache.org>.
aaltay merged PR #28013:
URL: https://github.com/apache/beam/pull/28013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] svetakvsundhar commented on pull request #28013: use google form for feedback
Posted by "svetakvsundhar (via GitHub)" <gi...@apache.org>.
svetakvsundhar commented on PR #28013:
URL: https://github.com/apache/beam/pull/28013#issuecomment-1689938998
@aaltay do you want to merge? Think it's safe to assume no objections will happen on the dev discussion list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #28013: use google form for feedback
Posted by "aaltay (via GitHub)" <gi...@apache.org>.
aaltay commented on PR #28013:
URL: https://github.com/apache/beam/pull/28013#issuecomment-1679631449
This LGTM. Happy to merge it. Should we give a few more days to the dev discussion thread? If there are no objections we can make this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] liferoad commented on pull request #28013: use google form for feedback
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #28013:
URL: https://github.com/apache/beam/pull/28013#issuecomment-1679565447
> Thanks! Right now, this form response will be populated into the backend Google Sheets. Do we want to integrate this with notifying the dev list?
This can be done easily as long as we agree with that. Not sure how noisy it will be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28013: use google form for feedback
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28013:
URL: https://github.com/apache/beam/pull/28013#issuecomment-1679573080
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @kennknowles added as fallback since no labels match configuration
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on a diff in pull request #28013: use google form for feedback
Posted by "aaltay (via GitHub)" <gi...@apache.org>.
aaltay commented on code in PR #28013:
URL: https://github.com/apache/beam/pull/28013#discussion_r1295118588
##########
website/www/site/layouts/partials/feedback.html:
##########
@@ -18,5 +18,5 @@ <h3>{{ T "feedback-title" }}</h3>
<p class="description">
{{ T "feedback-description" }}
</p>
- <button class="load-button"><a href="mailto:dev@beam.apache.org?subject=Beam Website Feedback">{{ T "feedback-button" }}</a></button>
Review Comment:
This is good.
Better would be: Is there a way to embed a very simple form?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] liferoad commented on pull request #28013: use google form for feedback
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #28013:
URL: https://github.com/apache/beam/pull/28013#issuecomment-1690625758
> Merged. Thank you!
>
> Could one of you please update the dev list thread and also change the form based on the feedback?
Will do later. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #28013: use google form for feedback
Posted by "aaltay (via GitHub)" <gi...@apache.org>.
aaltay commented on PR #28013:
URL: https://github.com/apache/beam/pull/28013#issuecomment-1690442516
Merged. Thank you!
Could one of you please update the dev list thread and also change the form based on the feedback?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] liferoad commented on a diff in pull request #28013: use google form for feedback
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on code in PR #28013:
URL: https://github.com/apache/beam/pull/28013#discussion_r1303530143
##########
website/www/site/layouts/partials/feedback.html:
##########
@@ -18,5 +18,5 @@ <h3>{{ T "feedback-title" }}</h3>
<p class="description">
{{ T "feedback-description" }}
</p>
- <button class="load-button"><a href="mailto:dev@beam.apache.org?subject=Beam Website Feedback">{{ T "feedback-button" }}</a></button>
Review Comment:
I will give it try later this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org