[GitHub] [pinot] walterddr commented on a change in pull request #7794: fix obfuscator not capturing secretkey and keytab

[GitBox <gi...@apache.org>]

walterddr commented on a change in pull request #7794:
URL: https://github.com/apache/pinot/pull/7794#discussion_r752521688



##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/utils/Obfuscator.java
##########
@@ -93,7 +94,8 @@ public Obfuscator(String maskedValue, List<Pattern> patterns) {
   public JsonNode toJson(Object object) {
     // NOTE: jayway json path 2.4.0 seems to have issues with '@.name' so we'll do this manually
     // as determined by a cursory and purely subjective investigation by alex
-    // "$..[?(@.name =~ /password$/i || @.name =~ /secret$/i || @.name =~ /token$/i)]"
+    // "$..[?(@.name =~ /password$/i || @.name =~ /secret$/i || @.name =~ /secretKey$/i || @.name =~ /keytab$/i

Review comment:
       ```suggestion
       // "$..[?(@.name =~ /password$/i || @.name =~ /secret$/i || @.name =~ /secret[\\s_-]*key$/i || @.name =~ /keytab$/i
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org