You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by vpernin <gi...@git.apache.org> on 2016/07/02 19:53:16 UTC
[GitHub] flink pull request #2192: Flink 4034 Maven dependency convergence
GitHub user vpernin opened a pull request:
https://github.com/apache/flink/pull/2192
Flink 4034 Maven dependency convergence
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vpernin/flink flink-4034-maven-dependency-convergence-yarn-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2192.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2192
----
commit aeaab14c62b89ec672ed59c26b672c14ce9fe188
Author: Vladislav Pernin <vl...@gmail.com>
Date: 2016-07-01T19:21:46Z
[FLINK-4034] Kafka IT does not work well on Windows, replace * by - in the Kafka temporary test folder path
commit e89adae0688ed40c187af193dc9ae6be721cdc1c
Author: Vladislav Pernin <vl...@gmail.com>
Date: 2016-07-01T19:26:43Z
[FLINK-4034] Enable file output of dependency plugin
commit e177491f64bd320b43035179de0330f19814f96c
Author: Vladislav Pernin <vl...@gmail.com>
Date: 2016-07-01T19:45:34Z
[FLINK-4034] Activation of Maven dependency convergence and resolution of dependencies conflicts among profiles
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2192: Flink 4034 Maven dependency convergence
Posted by vpernin <gi...@git.apache.org>.
Github user vpernin commented on the issue:
https://github.com/apache/flink/pull/2192
Hi,
I was on holidays.
I have to rebase on master and test again, hoping there is not too much new
conflicts.
2016-08-24 14:40 GMT+02:00 Stephan Ewen <no...@github.com>:
> Now that the release is out, I think we should start addressing this.
> @vpernin <https://github.com/vpernin> does this still work on the latest
> master version?
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/flink/pull/2192#issuecomment-242048229>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AAW2ZZr5CgbjVnMrcu8MxNpsXr9njNRrks5qjDvRgaJpZM4JDvbt>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2192: Flink 4034 Maven dependency convergence
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2192
Good idea in general.
I would use variables for all versions used more than once. For example, where ever `io.netty::netty` is used in version 3.x, it should probably refer to a variable which globally defines the version for that artifact.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2192: Flink 4034 Maven dependency convergence
Posted by vpernin <gi...@git.apache.org>.
Github user vpernin commented on the issue:
https://github.com/apache/flink/pull/2192
The builds 9896.1, 9896.2 and 9896.3 failed because of yarn tests or JMX reporter.
I do not have the right to restart these 3 jobs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2192: Flink 4034 Maven dependency convergence
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2192
---
[GitHub] flink issue #2192: Flink 4034 Maven dependency convergence
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2192
Now that the release is out, I think we should start addressing this. @vpernin does this still work on the latest master version?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---