You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "nrknithin (via GitHub)" <gi...@apache.org> on 2026/09/03 07:34:21 UTC
[PR] [incubator-kie-6902] Upgrade Quarkus to 3.33.3.1 (LTS)- #3987 [incubator-kie-examples]
nrknithin opened a new pull request, #2245:
URL: https://github.com/apache/incubator-kie-examples/pull/2245
**Related:** apache/incubator-kie#6903 (Quarkus 3.33.3.1 upgrade of the KIE runtimes)
**Follows:** apache/incubator-kie-examples#2244 (merged — `0f4075b3`)
#2244 moved the shared build configuration out of the examples root pom into the Quarkus and Spring Boot
aggregators, so the Maven examples now inherit their platform versions from the kie BOMs. Two things it could not
cover are left:
1. **Gradle cannot inherit from a Maven parent.** The Gradle examples still declare the Quarkus version literally,
and were still on 3.27.5.1.
2. **The root pom is the parent of the Java and Gradle trees only.** When the shared `pluginManagement` moved into
the two aggregators, those trees lost pins they had been relying on.
## What changed
**`gradle-examples/kogito-quarkus-gradle-examples/{dmn-quarkus-gradle,process-decisions-rules-quarkus-gradle}/gradle.properties`**
- `quarkusPluginVersion` and `quarkusPlatformVersion` 3.27.5.1 → **3.33.3.1**, matching `version.io.quarkus` in the
kie stack. The Spring Boot Gradle examples need no change: `springBootVersion` 4.0.7 already matches what
`kogito-springboot/bom` declares.
**`pom.xml` (examples root)**
- restore `version.org.eclipse.jkube` 1.4.0 and `pluginManagement` entries for `kubernetes-maven-plugin`,
`openshift-maven-plugin` and `maven-failsafe-plugin` (`${version.surefire.plugin}`).
## Why those pins matter
Measured by diffing the effective POM of all 81 modules against `main`, before restoring them:
- **`jkube` kubernetes/openshift-maven-plugin went from pinned 1.4.0 to *unversioned*** in 9 modules (the root
aggregator, `kogito-java-examples`, and the Gradle trees) — precisely the "Maven resolves the latest release"
hazard, which would make historical tags non-reproducible.
- **`maven-failsafe-plugin` silently dropped 3.3.1 → 3.2.5** in those same 9 modules, while `maven-surefire-plugin`
stayed at 3.3.1 — leaving the two mismatched within one build.
After this PR the only plugin-version differences against `main` are intended:
| plugin | main → branch | modules |
|---|---|---|
| `quarkus-maven-plugin` | 3.27.5.1 → 3.33.3.1 | 63 (the upgrade itself) |
| `maven-resources-plugin` | 2.5 → 3.1.0 | 79 (the old root pom pinned a 2012 version) |
| `quarkus-extension-maven-plugin` | **unversioned** → 3.33.3.1 | 69 (a float removed) |
| `quarkus-maven-plugin` | **unversioned** → 3.33.3.1 | 6 (a float removed) |
| `kogito-maven-plugin` | **unversioned** → 999-SNAPSHOT | 1 (a float removed) |
## Verification
- `mvn validate` over the whole repository: **BUILD SUCCESS**, 81 modules, zero
`'build.plugins.plugin.version' ... is missing` warnings, and the same **5** RELEASE-resolved core plugins as
`main` — all of them in the parentless `kjar` examples under `kogito-java-examples`, which is pre-existing.
- Effective-POM comparison of all 81 modules against `main`, as tabulated above: no unintended version moved.
- Gradle: both examples build on the repository's Gradle **9.2.1** wrapper with Quarkus 3.33.3.1 —
`gradlew clean test` → 8 tests, 0 failures, in each. `io.quarkus.platform:quarkus-bom:3.33.3.1` is on Maven
Central and the 3.33.3.1 Gradle plugin resolves from plugins.gradle.org (not Central), so the existing
`pluginManagement` repository entry in each `settings.gradle` remains load-bearing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-6902] Upgrade Quarkus to 3.33.3.2 (LTS)- #3987 [incubator-kie-examples]
Posted by "nrknithin (via GitHub)" <gi...@apache.org>.
nrknithin commented on PR #2245:
URL: https://github.com/apache/incubator-kie-examples/pull/2245#issuecomment-5574879764
> I have these findings in this PR:
>
> ### 01 junit
> All examples are affected by this:
>
> ```
> [WARNING] The artifact io.quarkus:quarkus-junit5:jar:3.33.3.2 has been relocated to io.quarkus:quarkus-junit:jar:3.33.3.2: Update the artifactId in your project build file. Refer to https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.31 for more information.
> ```
>
> ### 02 conf warnings
> ```
> INFO] --- quarkus:3.33.3.2:build (default) @ process-usertasks-timer-quarkus ---
> [WARNING] [io.quarkus.config] Unrecognized configuration key "kogito.persistence.type" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo
> [WARNING] [io.quarkus.config] Unrecognized configuration key "kogito.dataindex.ws.url" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo
> [WARNING] [io.quarkus.config] Unrecognized configuration key "quarkus.log.console.json" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo
> [WARNING] [io.quarkus.config] Unrecognized configuration key "kogito.dataindex.http.url" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo
> [WARNING] [io.quarkus.config] Unrecognized configuration key "quarkus.log.file.json.enabled" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo
> [WARNING] [io.quarkus.config] Unrecognized configuration key "kogito.jobs-service.url" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo
> ```
>
> could someone confirm these are or are not related to quarkus bump?
first one was an issue have fixed it, second one was a pre existing warning i think,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-6902] Upgrade Quarkus to 3.33.3.2 (LTS)- #3987 [incubator-kie-examples]
Posted by "nrknithin (via GitHub)" <gi...@apache.org>.
nrknithin commented on code in PR #2245:
URL: https://github.com/apache/incubator-kie-examples/pull/2245#discussion_r3949099107
##########
pom.xml:
##########
@@ -152,6 +154,23 @@
<skip>true</skip>
</configuration>
</plugin>
+ <!-- Kept pinned here for the Java and Gradle examples, which inherit from this pom: failsafe must
+ track surefire (${version.surefire.plugin}), and the JKube plugins must not resolve to LATEST. -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-failsafe-plugin</artifactId>
+ <version>${version.surefire.plugin}</version>
+ </plugin>
+ <plugin>
+ <groupId>org.eclipse.jkube</groupId>
+ <artifactId>kubernetes-maven-plugin</artifactId>
+ <version>${version.org.eclipse.jkube}</version>
+ </plugin>
+ <plugin>
+ <groupId>org.eclipse.jkube</groupId>
+ <artifactId>openshift-maven-plugin</artifactId>
+ <version>${version.org.eclipse.jkube}</version>
+ </plugin>
Review Comment:
same as above
##########
pom.xml:
##########
@@ -103,6 +103,8 @@
<!-- Reproducible builds -->
<project.build.outputTimestamp>2024-01-16T00:00:00Z</project.build.outputTimestamp>
<version.maven.artifact.plugin>3.4.1</version.maven.artifact.plugin>
+ <!-- JKube -->
+ <version.org.eclipse.jkube>1.4.0</version.org.eclipse.jkube>
Review Comment:
#2244 moved the shared pluginManagement into the aggregators, so I initially added the pin here. But JKube isn't actually used in these trees, so it isn't needed and I've removed it.
##########
gradle-examples/kogito-quarkus-gradle-examples/dmn-quarkus-gradle/gradle.properties:
##########
@@ -1,10 +1,11 @@
#Gradle properties
-## 3.27.5.1 needed to support gradle 9.2
+## Quarkus 3.27+ is required for Gradle 9.2 support (wrapper: 9.2.1). Gradle cannot inherit from the
+## Maven parent, so this pin is maintained by hand and must track the kie stack (version.io.quarkus).
Review Comment:
You're right, the comment was outdated and misleading, so I removed it. The Spring Boot Gradle examples don't have one either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-6902] Upgrade Quarkus to 3.33.3.2 (LTS)- #3987 [incubator-kie-examples]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #2245:
URL: https://github.com/apache/incubator-kie-examples/pull/2245#discussion_r3948612467
##########
pom.xml:
##########
@@ -103,6 +103,8 @@
<!-- Reproducible builds -->
<project.build.outputTimestamp>2024-01-16T00:00:00Z</project.build.outputTimestamp>
<version.maven.artifact.plugin>3.4.1</version.maven.artifact.plugin>
+ <!-- JKube -->
+ <version.org.eclipse.jkube>1.4.0</version.org.eclipse.jkube>
Review Comment:
@nrknithin Can you explain the reason we need this?
##########
gradle-examples/kogito-quarkus-gradle-examples/dmn-quarkus-gradle/gradle.properties:
##########
@@ -1,10 +1,11 @@
#Gradle properties
-## 3.27.5.1 needed to support gradle 9.2
+## Quarkus 3.27+ is required for Gradle 9.2 support (wrapper: 9.2.1). Gradle cannot inherit from the
+## Maven parent, so this pin is maintained by hand and must track the kie stack (version.io.quarkus).
Review Comment:
@nrknithin I don't know if keeping this comment still makes sense, WDYT @gitgabrio ?
##########
pom.xml:
##########
@@ -152,6 +154,23 @@
<skip>true</skip>
</configuration>
</plugin>
+ <!-- Kept pinned here for the Java and Gradle examples, which inherit from this pom: failsafe must
+ track surefire (${version.surefire.plugin}), and the JKube plugins must not resolve to LATEST. -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-failsafe-plugin</artifactId>
+ <version>${version.surefire.plugin}</version>
+ </plugin>
+ <plugin>
+ <groupId>org.eclipse.jkube</groupId>
+ <artifactId>kubernetes-maven-plugin</artifactId>
+ <version>${version.org.eclipse.jkube}</version>
+ </plugin>
+ <plugin>
+ <groupId>org.eclipse.jkube</groupId>
+ <artifactId>openshift-maven-plugin</artifactId>
+ <version>${version.org.eclipse.jkube}</version>
+ </plugin>
Review Comment:
@nrknithin Same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-6902] Upgrade Quarkus to 3.33.3.2 (LTS)- #3987 [incubator-kie-examples]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer merged PR #2245:
URL: https://github.com/apache/incubator-kie-examples/pull/2245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-6902] Upgrade Quarkus to 3.33.3.2 (LTS)- #3987 [incubator-kie-examples]
Posted by "nrknithin (via GitHub)" <gi...@apache.org>.
nrknithin commented on PR #2245:
URL: https://github.com/apache/incubator-kie-examples/pull/2245#issuecomment-5569688800
@yesamer Thanks for the views have updated the code and replied back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-6902] Upgrade Quarkus to 3.33.3.2 (LTS)- #3987 [incubator-kie-examples]
Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #2245:
URL: https://github.com/apache/incubator-kie-examples/pull/2245#discussion_r3949022997
##########
gradle-examples/kogito-quarkus-gradle-examples/dmn-quarkus-gradle/gradle.properties:
##########
@@ -1,10 +1,11 @@
#Gradle properties
-## 3.27.5.1 needed to support gradle 9.2
+## Quarkus 3.27+ is required for Gradle 9.2 support (wrapper: 9.2.1). Gradle cannot inherit from the
+## Maven parent, so this pin is maintained by hand and must track the kie stack (version.io.quarkus).
Review Comment:
No strong opinion... maybe it is useful just to remember, in future, which minimum version is required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org