You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/01 07:47:00 UTC

[GitHub] [pulsar] lhotari opened a new pull request #14502: [Functions] Pass configured metricsPort to k8s runtime

lhotari opened a new pull request #14502:
URL: https://github.com/apache/pulsar/pull/14502


   ### Motivation
   
   PR #9610 made changes in the way that metricsPort is handled in Pulsar Functions Kubernetes Runtime. This broke metrics for Pulsar Functions.
   
   ### Additional context
   
   There's also an alternative fix #14085 . That PR lacks tests and doesn't handle the case where metrics are disabled by setting metricsPort to an empty value.
   
   ### Modifications
   
   - pass metricsPort configured in functionRuntimeFactoryConfigs.metricsPort in functions_worker.yml on to KubernetesRuntime in the InstanceConfig instance since #9610 made this change.
   - handle the case where metricsPort is set to an empty value. In this case, don't add the Prometheus scraping annotations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #14502: [Functions] Pass configured metricsPort to k8s runtime

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14502:
URL: https://github.com/apache/pulsar/pull/14502#issuecomment-1055126575


   @lhotari:Thanks for providing doc info!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] zzzming commented on pull request #14502: [Functions] Pass configured metricsPort to k8s runtime

Posted by GitBox <gi...@apache.org>.
zzzming commented on pull request #14502:
URL: https://github.com/apache/pulsar/pull/14502#issuecomment-1055611528


   LGTM
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #14502: [Functions] Pass configured metricsPort to k8s runtime

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14502:
URL: https://github.com/apache/pulsar/pull/14502#issuecomment-1055120792


   @lhotari:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #14502: [Functions] Pass configured metricsPort to k8s runtime

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #14502:
URL: https://github.com/apache/pulsar/pull/14502#issuecomment-1055910506


   @freeznet please review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari merged pull request #14502: [Functions] Pass configured metricsPort to k8s runtime

Posted by GitBox <gi...@apache.org>.
lhotari merged pull request #14502:
URL: https://github.com/apache/pulsar/pull/14502


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org