You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "HuangTao (Jira)" <ji...@apache.org> on 2020/04/15 10:46:00 UTC

[jira] [Commented] (HDFS-15140) Replace FoldedTreeSet in Datanode with SortedSet or TreeMap

    [ https://issues.apache.org/jira/browse/HDFS-15140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083996#comment-17083996 ] 

HuangTao commented on HDFS-15140:
---------------------------------

about the patch, I find two points need to change
{code}
           ReplicaInfo orig = b.getOriginalReplica();
-          builders.get(volStorageID).add(orig);
+          unsortedBlocks.get(volStorageID).add(b); # replace b with orig
{code}

{code}
+        unsortedBlocks.put(
+            v.getStorageID(), new ArrayList<ReplicaInfo>(131072)); # should use a constant variable
{code}

> Replace FoldedTreeSet in Datanode with SortedSet or TreeMap
> -----------------------------------------------------------
>
>                 Key: HDFS-15140
>                 URL: https://issues.apache.org/jira/browse/HDFS-15140
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 3.3.0
>            Reporter: Stephen O'Donnell
>            Assignee: Stephen O'Donnell
>            Priority: Major
>         Attachments: HDFS-15140.001.patch, HDFS-15140.002.patch
>
>
> Based on the problems discussed in HDFS-15131, I would like to explore replacing the FoldedTreeSet structure in the datanode with a builtin Java equivalent - either SortedSet or TreeMap.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org